commit b3b3a5ba64eed874774985b93ce50b889575382e
author Jim Schaad <ietf@augustcellars.com> Mon Jun 12 10:58:45 2017 -0700
committer Jim Schaad <ietf@augustcellars.com> Mon Jun 12 10:58:45 2017 -0700
tree a8f9b80a8c08285341ff49f4821721e360ad7e64
parent 20e455e96c3ca564ec210f87b603269079e49f7c

Fix errors

Need to check allocation for r & s
reverse sense of check for alloction of sig

src/openssl.c

diff --git a/src/openssl.c b/src/openssl.c
index 5482b66..671c7f7 100644
--- a/src/openssl.c
+++ b/src/openssl.c
@@ -1072,7 +1072,7 @@
 	cn_cbor * pSig;
 	size_t cbSignature;
 
-	const BIGNUM *r, *s;
+	BIGNUM *r, *s;
 
 	eckey = ECKey_From(pKey, &cbR, perr);
 	if (eckey == NULL) {
@@ -1098,10 +1098,12 @@
 
 	CHECK_CONDITION(cbSignature / 2 == cbR, COSE_ERR_INVALID_PARAMETER);
 	r = BN_bin2bn(pSig->v.bytes,(int) cbSignature/2, NULL);
+	CHECK_CONDITION(NULL != r, COSE_ERR_OUT_OF_MEMORY);
 	s = BN_bin2bn(pSig->v.bytes+cbSignature/2, (int) cbSignature/2, NULL);
+	CHECK_CONDITION(NULL != s, COSE_ERR_OUT_OF_MEMORY);
 
 	sig = ECDSA_SIG_new();
-	CHECK_CONDITION(sig == NULL, COSE_ERR_OUT_OF_MEMORY);
+	CHECK_CONDITION(sig != NULL, COSE_ERR_OUT_OF_MEMORY);
 
 	ECDSA_SIG_set0(sig, r, s);