commit 10088504350a1b7192615382828fa8662c79949e
author Alex Karatarakis <alex@karatarakis.com> Wed Jun 23 14:57:22 2021 -0700
committer Alex Karatarakis <alex@karatarakis.com> Wed Jun 23 14:57:22 2021 -0700
tree 7f0a31e5d090fcf1a56dc9a595a58dc00b4a7189
parent 355d57d90d9744c41ac7c99f1e960778f1c63040

Fix EXPECT_DEATH() and ASSERT_DEATH() triggering -Wcovered-switch-default


EXPECT_DEATH() and ASSERT_DEATH() have a switch case where every
possible case is covered. This makes the default case unnecessary
and triggers -Wcovered-switch-default.
Due to these being macros, the lines are expanded in user code and
are thus subject to warnings of the target codebase.

Fixes #3456

googletest/include/gtest/internal/gtest-death-test-internal.h

diff --git a/googletest/include/gtest/internal/gtest-death-test-internal.h b/googletest/include/gtest/internal/gtest-death-test-internal.h
index 490296d..867a840 100644
--- a/googletest/include/gtest/internal/gtest-death-test-internal.h
+++ b/googletest/include/gtest/internal/gtest-death-test-internal.h
@@ -236,8 +236,6 @@
           gtest_dt->Abort(::testing::internal::DeathTest::TEST_DID_NOT_DIE);   \
           break;                                                               \
         }                                                                      \
-        default:                                                               \
-          break;                                                               \
       }                                                                        \
     }                                                                          \
   } else                                                                       \