| commit | 200c7ea1fbf9d3d64dbdd459f5ac7a9908103247 | [log] [tgz] |
|---|---|---|
| author | Jason C <JC3@users.noreply.github.com> | Tue May 04 18:04:13 2021 -0400 |
| committer | GitHub <noreply@github.com> | Tue May 04 18:04:13 2021 -0400 |
| tree | 0f527aff5408b1dfe80f0e2fc632abde00dd46f3 | |
| parent | f5e592d8ee5ffb1d9af5be7f715ce3576b8bf9c4 [diff] |
isalnum -> IsAlNum for correct handling of signed chars I spotted this in https://github.com/assimp/assimp/pull/3880/commits/7dd7a053a91322fad88cdf958c6d0b3b7b91cb90 and figured I'd fix it here, too. If this is not the right thing to do, please lmk so I can undo it in assimp, too. Seems right, though. It's the only spot in gtest where a ctype call was made directly.
diff --git a/googletest/include/gtest/internal/gtest-param-util.h b/googletest/include/gtest/internal/gtest-param-util.h index 3e49a6b..ed5d467 100644 --- a/googletest/include/gtest/internal/gtest-param-util.h +++ b/googletest/include/gtest/internal/gtest-param-util.h
@@ -654,7 +654,7 @@ // Check for invalid characters for (std::string::size_type index = 0; index < name.size(); ++index) { - if (!isalnum(name[index]) && name[index] != '_') + if (!IsAlNum(name[index]) && name[index] != '_') return false; }