commit 7d294ab4f2e0ed749b4bcfaf533225a4e0c096f7
author Kazuho Oku <kazuhooku@gmail.com> Sat Dec 10 01:56:28 2022 +0900
committer GitHub <noreply@github.com> Sat Dec 10 01:56:28 2022 +0900
tree 5108ab8640d7d3f36866a06f2a55ea75eedb646f
parent 4e57e9b09ebac4da4c28433e20e5a88ffa972a08
parent 3531e9bcc7835d8b1fea02533b40ccc9ed3be7d6

Merge pull request #452 from h2o/kazuho/async-sign-quic

async signature generation for QUIC

include/picotls.h

diff --git a/include/picotls.h b/include/picotls.h
index fe74d40..e2a4366 100644
--- a/include/picotls.h
+++ b/include/picotls.h
@@ -1632,7 +1632,7 @@
 static size_t ptls_aead_decrypt(ptls_aead_context_t *ctx, void *output, const void *input, size_t inlen, uint64_t seq,
                                 const void *aad, size_t aadlen);
 /**
- * Return the current read epoch.
+ * Return the current read epoch (i.e., that of the message being received or to be)
  */
 size_t ptls_get_read_epoch(ptls_t *tls);
 /**

lib/picotls.c

diff --git a/lib/picotls.c b/lib/picotls.c
index 83ac410..a712c85 100644
--- a/lib/picotls.c
+++ b/lib/picotls.c
@@ -6317,6 +6317,7 @@
     case PTLS_STATE_CLIENT_EXPECT_CERTIFICATE:
     case PTLS_STATE_CLIENT_EXPECT_CERTIFICATE_VERIFY:
     case PTLS_STATE_CLIENT_EXPECT_FINISHED:
+    case PTLS_STATE_SERVER_GENERATING_CERTIFICATE_VERIFY:
     case PTLS_STATE_SERVER_EXPECT_CERTIFICATE:
     case PTLS_STATE_SERVER_EXPECT_CERTIFICATE_VERIFY:
     case PTLS_STATE_SERVER_EXPECT_FINISHED:
@@ -6365,12 +6366,11 @@
     struct st_ptls_record_t rec = {PTLS_CONTENT_TYPE_HANDSHAKE, 0, inlen, input};
 
     if (tls->state == PTLS_STATE_SERVER_GENERATING_CERTIFICATE_VERIFY) {
-        int ret;
-        if ((ret = server_finish_handshake(tls, &emitter.super, 1, NULL)) != 0)
-            return ret;
+        assert(input == NULL || inlen == 0);
+        return server_finish_handshake(tls, &emitter.super, 1, NULL);
     }
 
-    assert(input);
+    assert(input != NULL);
 
     if (ptls_get_read_epoch(tls) != in_epoch)
         return PTLS_ALERT_UNEXPECTED_MESSAGE;