commit 37aa79a2f661c036129cfe559f26265763f07418
author Petteri Aimonen <jpa@git.mail.kapsi.fi> Sun Jan 12 13:31:21 2020 +0200
committer Petteri Aimonen <jpa@git.mail.kapsi.fi> Sun Jan 12 13:31:21 2020 +0200
tree 3b4d430abd8fe67ea33da63d9d11c5c46dc6ca9a
parent 521daea85ea78d4c83d9f85eb1313c2aec3272e4

Add tests for error detection in fixed size arrays.

tests/fixed_count/fixed_count_unittests.c

diff --git a/tests/fixed_count/fixed_count_unittests.c b/tests/fixed_count/fixed_count_unittests.c
index 02bacac..b039c9b 100644
--- a/tests/fixed_count/fixed_count_unittests.c
+++ b/tests/fixed_count/fixed_count_unittests.c
@@ -8,7 +8,6 @@
 int main()
 {
     int status = 0;
-    COMMENT("Test encoding and decoding of repeated fixed count fields");
 
     {
       pb_byte_t buffer[Message1_size];
@@ -23,6 +22,8 @@
       msg_a.data[0] = 2;
       msg_a.data[0] = 3;
 
+      COMMENT("Test encode and decode with three entries");
+
       ostream = pb_ostream_from_buffer(buffer, Message1_size);
       TEST(pb_encode(&ostream, Message1_fields, &msg_a));
       message_length = ostream.bytes_written;
@@ -35,6 +36,26 @@
     }
 
     {
+      pb_byte_t input[] = {0x08, 0x00, 0x08, 0x01, 0x08, 0x02, 0x08, 0x03};
+      pb_istream_t stream;
+      Message1 msg = Message1_init_zero;
+
+      COMMENT("Test wrong number of entries");
+
+      stream = pb_istream_from_buffer(input, 6);
+      TEST(pb_decode(&stream, Message1_fields, &msg));
+      TEST(msg.data[0] == 0 && msg.data[1] == 1 && msg.data[2] == 2);
+
+      stream = pb_istream_from_buffer(input, 8);
+      TEST(!pb_decode(&stream, Message1_fields, &msg));
+      TEST(strcmp(stream.errmsg, "array overflow") == 0);
+
+      stream = pb_istream_from_buffer(input, 4);
+      TEST(!pb_decode(&stream, Message1_fields, &msg));
+      TEST(strcmp(stream.errmsg, "wrong size for fixed count field") == 0);
+    }
+
+    {
       pb_byte_t buffer[Message2_size];
       Message2 msg_a = Message2_init_zero;
       Message2 msg_b = Message2_init_zero;
@@ -43,6 +64,8 @@
       pb_istream_t istream;
       size_t message_length;
 
+      COMMENT("Test encode and decode with nested messages");
+
       msg_a.data[0].data[0] = 1;
       msg_a.data[0].data[1] = 2;
       msg_a.data[0].data[2] = 3;
@@ -70,6 +93,8 @@
       pb_istream_t istream;
       size_t message_length;
 
+      COMMENT("Test encode and decode with two nested messages");
+
       msg_a.data1[0].data[0].data[0] = 1;
       msg_a.data1[0].data[0].data[1] = 2;
       msg_a.data1[0].data[0].data[2] = 3;