commit 21b1e5af2c46e5057ade5b901d8664e30146e575
author Michael Spang <spang@google.com> Thu Jul 28 23:15:48 2022 -0400
committer GitHub <noreply@github.com> Thu Jul 28 23:15:48 2022 -0400
tree 9e0c2b0bbcf2a324b7b8d9ece776560b56bb3841
parent ae2ca6d22e6594614df712fec3becad8e6ef2c6c

Disable -Wl,-z,defs in ASAN build (#21381)

Shared libraries built with address sanitizer have some unresolved
symbols created by the instrumentation. These will be provided by
the executable.

This is by design but trips an unresolved symbol diagnostic. Disable
these strictures when ASAN is enabled.

build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 0d7e484..c23d35b 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -262,7 +262,7 @@
     ]
   }
 
-  if (current_os == "linux" || current_os == "android") {
+  if (!is_asan && (current_os == "linux" || current_os == "android")) {
     ldflags += [ "-Wl,-z,defs" ]
   }
 }