Allow the python extension to be built by wildcards (#13)
Removed manual tag
Co-authored-by: chuckx <chuckx@cold-sun.com>
diff --git a/README.md b/README.md
index 8ef2eb3..0091692 100644
--- a/README.md
+++ b/README.md
@@ -3,13 +3,13 @@
Provided rules:
- `pybind_extension`: Builds a python extension, automatically adding the
- required build flags and pybind11 dependencies. It also defines a .so target
- which can be manually built and copied. The arguments match a `py_extension`.
+ required build flags and pybind11 dependencies. It defines a `*.so` target
+ which can be included as a `data` dependency of a `py_*` target.
- `pybind_library`: Builds a C++ library, automatically adding the required
build flags and pybind11 dependencies. This library can then be used as a
dependency of a `pybind_extension`. The arguments match a `cc_library`.
- `pybind_library_test`: Builds a C++ test for a `pybind_library`. The arguments
- match a cc_test.
+ match a `cc_test`.
To test a `pybind_extension`, the most common approach is to write the test in
python and use the standard `py_test` build rule.
diff --git a/build_defs.bzl b/build_defs.bzl
index 204724e..4b99f83 100644
--- a/build_defs.bzl
+++ b/build_defs.bzl
@@ -24,7 +24,7 @@
# Builds a Python extension module using pybind11.
# This can be directly used in python with the import statement.
-# This adds rules for a .so binary file, which must be built manually.
+# This adds rules for a .so binary file.
def pybind_extension(
name,
copts = [],
@@ -45,7 +45,7 @@
"//conditions:default": ["-Wl,-Bsymbolic"],
}),
linkshared = 1,
- tags = tags + ["local", "manual"],
+ tags = tags + ["local"],
deps = deps + PYBIND_DEPS,
**kwargs
)