commit 13df15845e9b80e53d68ec71959ad0a05c40f916
author Marc Herbert <marc.herbert@intel.com> Fri Dec 01 00:23:22 2023 +0000
committer Carles Cufí <carles.cufi@nordicsemi.no> Wed Dec 13 13:56:59 2023 +0100
tree 326c814562e1d78acfed18307cd4048dc214d067
parent fbfd36e81e2aa2dcd9699faf69645c1f60374aac

cmake: drop ERROR_QUIET in python.cmake

ERROR_QUIET should be used only when the command is actually expected to
fail, otherwise discarding stderr can be extremely time-consuming. See
recent example of time lost in commit 40c2e08e8211 ("xcc/cmake: don't
discard stderr; don't (ever!) use ERROR_QUIET")

If some Python interpreter cannot even evaluate `sys.version_info[:2]`,
then we definitely don't want to hide what its stderr says about that.

Fixes commit 94de3e9f60dc ("cmake: FindPython3: Adjust python3 program
search")

Signed-off-by: Marc Herbert <marc.herbert@intel.com>

cmake/modules/python.cmake

diff --git a/cmake/modules/python.cmake b/cmake/modules/python.cmake
index 78a2995..6fc765f 100644
--- a/cmake/modules/python.cmake
+++ b/cmake/modules/python.cmake
@@ -31,7 +31,6 @@
                                  "import sys; sys.stdout.write('.'.join([str(x) for x in sys.version_info[:2]]))"
                          RESULT_VARIABLE result
                          OUTPUT_VARIABLE version
-                         ERROR_QUIET
                          OUTPUT_STRIP_TRAILING_WHITESPACE)
 
        if(version VERSION_LESS PYTHON_MINIMUM_REQUIRED)