commit 24f345ee3e005294725c97eea55a993321c81bfb
author Armando Visconti <armando.visconti@st.com> Wed May 12 14:07:59 2021 +0200
committer Kumar Gala <kumar.gala@gmail.com> Wed May 12 23:34:46 2021 -0500
tree bd6e53d9be50c87241cf1dcffe11536983c95ab3
parent 09a85ff84b1bba34e7bb2031732c652b90212bff

drivers/sensor: iis2mdc: use gpio_dt_spec oriented macros

Use gpio_pin_configure_dt() and gpio_pin_interrupt_configure_dt()
for drdy_gpio: they result in a more readable code.

Moreover, this commit includes also the fix for PR #35156
(i.e. CID 235979, add check for gpio_pin_configure() return val).

Signed-off-by: Armando Visconti <armando.visconti@st.com>

drivers/sensor/iis2mdc/iis2mdc_trigger.c

diff --git a/drivers/sensor/iis2mdc/iis2mdc_trigger.c b/drivers/sensor/iis2mdc/iis2mdc_trigger.c
index 3df5420..b8deff6 100644
--- a/drivers/sensor/iis2mdc/iis2mdc_trigger.c
+++ b/drivers/sensor/iis2mdc/iis2mdc_trigger.c
@@ -62,8 +62,8 @@
 		iis2mdc->handler_drdy(dev, &drdy_trigger);
 	}
 
-	gpio_pin_interrupt_configure(config->gpio_drdy.port, config->gpio_drdy.pin,
-				     GPIO_INT_EDGE_TO_ACTIVE);
+	gpio_pin_interrupt_configure_dt(&config->gpio_drdy,
+					GPIO_INT_EDGE_TO_ACTIVE);
 }
 
 static void iis2mdc_gpio_callback(const struct device *dev,
@@ -75,7 +75,7 @@
 
 	ARG_UNUSED(pins);
 
-	gpio_pin_interrupt_configure(dev, config->gpio_drdy.pin, GPIO_INT_DISABLE);
+	gpio_pin_interrupt_configure_dt(&config->gpio_drdy, GPIO_INT_DISABLE);
 
 #if defined(CONFIG_IIS2MDC_TRIGGER_OWN_THREAD)
 	k_sem_give(&iis2mdc->gpio_sem);
@@ -108,6 +108,7 @@
 {
 	struct iis2mdc_data *iis2mdc = dev->data;
 	const struct iis2mdc_dev_config *const config = dev->config;
+	int ret;
 
 	/* setup data ready gpio interrupt */
 	if (!device_is_ready(config->gpio_drdy.port)) {
@@ -126,8 +127,11 @@
 	iis2mdc->work.handler = iis2mdc_work_cb;
 #endif
 
-	gpio_pin_configure(config->gpio_drdy.port, config->gpio_drdy.pin,
-			   GPIO_INPUT | config->gpio_drdy.dt_flags);
+	ret = gpio_pin_configure_dt(&config->gpio_drdy, GPIO_INPUT);
+	if (ret < 0) {
+		LOG_ERR("Could not configure gpio");
+		return ret;
+	}
 
 	gpio_init_callback(&iis2mdc->gpio_cb,
 			   iis2mdc_gpio_callback,
@@ -138,6 +142,6 @@
 		return -EIO;
 	}
 
-	return gpio_pin_interrupt_configure(config->gpio_drdy.port, config->gpio_drdy.pin,
-					    GPIO_INT_EDGE_TO_ACTIVE);
+	return gpio_pin_interrupt_configure_dt(&config->gpio_drdy,
+					       GPIO_INT_EDGE_TO_ACTIVE);
 }