commit 28080d389686bb21386cff7ee68a148fa7795647
author Adithya Baglody <adithya.nagaraj.baglody@intel.com> Mon Oct 15 11:48:51 2018 +0530
committer Anas Nashif <anas.nashif@intel.com> Wed Oct 17 07:59:51 2018 -0400
tree 9364882486e40898fe5472893426d9eea6027672
parent 1424561252f9e42543a4cb742eef76f4c262fb63

kernel: MISRA C: Fixes a few MISRA C issues.

MISRA C guideline compliance for various rules.

Signed-off-by: Adithya Baglody <adithya.nagaraj.baglody@intel.com>

kernel/stack.c

diff --git a/kernel/stack.c b/kernel/stack.c
index fccb5a8..7924b8f 100644
--- a/kernel/stack.c
+++ b/kernel/stack.c
@@ -46,26 +46,27 @@
 #endif /* CONFIG_OBJECT_TRACING */
 
 void k_stack_init(struct k_stack *stack, u32_t *buffer,
-			unsigned int num_entries)
+		  u32_t num_entries)
 {
 	_waitq_init(&stack->wait_q);
-	stack->next = stack->base = buffer;
+	stack->base = buffer;
+	stack->next = buffer;
 	stack->top = stack->base + num_entries;
 
 	SYS_TRACING_OBJ_INIT(k_stack, stack);
 	_k_object_init(stack);
 }
 
-int _impl_k_stack_alloc_init(struct k_stack *stack, unsigned int num_entries)
+s32_t _impl_k_stack_alloc_init(struct k_stack *stack, u32_t num_entries)
 {
 	void *buffer;
-	int ret;
+	s32_t ret;
 
 	buffer = z_thread_malloc(num_entries);
 	if (buffer != NULL) {
 		k_stack_init(stack, buffer, num_entries);
 		stack->flags = K_STACK_FLAG_ALLOC;
-		ret = 0;
+		ret = (s32_t)0;
 	} else {
 		ret = -ENOMEM;
 	}
@@ -85,9 +86,9 @@
 
 void k_stack_cleanup(struct k_stack *stack)
 {
-	__ASSERT_NO_MSG(!_waitq_head(&stack->wait_q));
+	__ASSERT_NO_MSG(_waitq_head(&stack->wait_q) == NULL);
 
-	if (stack->flags & K_STACK_FLAG_ALLOC) {
+	if ((stack->flags & K_STACK_FLAG_ALLOC) != (u8_t)0) {
 		k_free(stack->base);
 		stack->base = NULL;
 		stack->flags &= ~K_STACK_FLAG_ALLOC;
@@ -97,7 +98,7 @@
 void _impl_k_stack_push(struct k_stack *stack, u32_t data)
 {
 	struct k_thread *first_pending_thread;
-	unsigned int key;
+	u32_t key;
 
 	__ASSERT(stack->next != stack->top, "stack is full");
 
@@ -136,7 +137,7 @@
 
 int _impl_k_stack_pop(struct k_stack *stack, u32_t *data, s32_t timeout)
 {
-	unsigned int key;
+	u32_t key;
 	int result;
 
 	key = irq_lock();