commit 62ab576a6a375baab27a4d51a86f0943e662cb7b
author Andrei Emeltchenko <andrei.emeltchenko@intel.com> Fri Jan 27 12:36:51 2023 +0200
committer Stephanos Ioannidis <root@stephanos.io> Sat Jan 28 08:55:41 2023 +0900
tree 3c69ec8ff78a7d95dbb7c91efbafd6143f6a7fde
parent f675cf13580cdf8a753b944540251645c52014a7

logging: shell: Fix using uninitialized variables

Fixes using uninitialized variables using returns with correct return
code.

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>

subsys/logging/log_cmds.c

diff --git a/subsys/logging/log_cmds.c b/subsys/logging/log_cmds.c
index a50dd6f..ea3c297 100644
--- a/subsys/logging/log_cmds.c
+++ b/subsys/logging/log_cmds.c
@@ -363,14 +363,17 @@
 	err = log_mem_get_usage(&size, &used);
 	if (err < 0) {
 		shell_error(sh, "Failed to get usage (mode does not support it?)");
+		return -ENOEXEC;
 	}
 
 	shell_print(sh, "Log message buffer utilization report:");
 	shell_print(sh, "\tCapacity: %u bytes", size);
 	shell_print(sh, "\tCurrently in use: %u bytes", used);
+
 	err = log_mem_get_max_usage(&max);
 	if (err < 0) {
 		shell_print(sh, "Enable CONFIG_LOG_MEM_UTILIZATION to get maximum usage");
+		return 0;
 	}
 
 	shell_print(sh, "\tMaximum usage: %u bytes", max);