commit 68a4d0f6c57a93c561df6daa3dc0e581de03b22b
author Emil Gydesen <emil.gydesen@nordicsemi.no> Thu Aug 31 15:30:31 2023 +0200
committer Carles Cufí <carles.cufi@nordicsemi.no> Fri Sep 01 17:45:07 2023 +0200
tree 3e9d0f4e693b5099a9c85462deebe907f5c3ed06
parent 3c34ca6fb9780e5414cd4833fd21ad715ac0a4d3

Bluetooth: BAP: Broadcast Source: Modify when enabling state is set

Modify when the BT_BAP_EP_STATE_ENABLING state is set during
bt_bap_broadcast_source_start.

The reason why the state is now set before the call to
bt_iso_big_create, is to handle the case where the BIG
created event actually happens and is handled (by another
thread) faster than the state change is done, which could
cause an invalid state check if the streaming state is
attempted to be set before the enabling state.

Since the events from the controller may be handled by a
different thread, we should not assume that this function returns
before the event is handled.

Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>

subsys/bluetooth/audio/bap_broadcast_source.c

diff --git a/subsys/bluetooth/audio/bap_broadcast_source.c b/subsys/bluetooth/audio/bap_broadcast_source.c
index 467c753..4fa436e 100644
--- a/subsys/bluetooth/audio/bap_broadcast_source.c
+++ b/subsys/bluetooth/audio/bap_broadcast_source.c
@@ -175,7 +175,7 @@
 	if (ops != NULL && ops->started != NULL) {
 		ops->started(stream);
 	} else {
-		LOG_WRN("No callback for connected set");
+		LOG_WRN("No callback for started set");
 	}
 }
 
@@ -884,14 +884,19 @@
 			     sizeof(param.bcode));
 	}
 
+	/* Set the enabling state early in case that the BIS is connected before we can manage to
+	 * set it afterwards
+	 */
+	broadcast_source_set_state(source, BT_BAP_EP_STATE_ENABLING);
+
 	err = bt_iso_big_create(adv, &param, &source->big);
 	if (err != 0) {
 		LOG_DBG("Failed to create BIG: %d", err);
+		broadcast_source_set_state(source, BT_BAP_EP_STATE_QOS_CONFIGURED);
+
 		return err;
 	}
 
-	broadcast_source_set_state(source, BT_BAP_EP_STATE_ENABLING);
-
 	return 0;
 }