commit 92d1d1ab2f1d831c599485e91ea421fe98116f6d
author Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no> Wed May 12 07:34:30 2021 +0200
committer Kumar Gala <kumar.gala@gmail.com> Wed May 12 23:36:01 2021 -0500
tree a2dc2d1c0c684a6f0cb92530182c657f95eccf20
parent f5be847e6dacc562ef47a128107fe1a91834f147

tests: logging: log_msg2: Prevent using negative array index

Move assert check before array access to ensure that
negative index is not used in an array. Coverity CID 222151.

Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>

tests/subsys/logging/log_msg2/src/main.c

diff --git a/tests/subsys/logging/log_msg2/src/main.c b/tests/subsys/logging/log_msg2/src/main.c
index ed43b7c..b51172e 100644
--- a/tests/subsys/logging/log_msg2/src/main.c
+++ b/tests/subsys/logging/log_msg2/src/main.c
@@ -108,8 +108,8 @@
 	d = log_msg2_get_package(msg, &len);
 	if (str) {
 		rv = cbpprintf(out, &tbuf, d);
-		buf[rv] = '\0';
 		zassert_true(rv > 0, NULL);
+		buf[rv] = '\0';
 
 		rv = strncmp(buf, str, sizeof(buf));
 		zassert_equal(rv, 0, "expected:\n%s,\ngot:\n%s", str, buf);