commit b8ff36f57af3dd108b8f374d8937caabc32482fb
author Maxim Adelman <imax@meta.com> Wed Jun 14 11:33:14 2023 -0400
committer Andrei Emeltchenko <andrei.emeltchenko@intel.com> Tue Oct 31 19:14:45 2023 +0200
tree 3ab21a56e37f2cdd6bad56f3ae4a524ce93ac4c4
parent 2e98b1fd8ca4bc70272dc56c321c6c08508fbeb7

kernel shell, stacks shell commands: iterate unlocked on SMP

call k_thread_foreach_unlocked to avoid assertions caused
by calling shell_print while holding a global lock

Signed-off-by: Maxim Adelman <imax@meta.com>
(cherry picked from commit ecf2cb5932156c889b7886609a652abe79cc16fa)

subsys/shell/modules/kernel_service.c

diff --git a/subsys/shell/modules/kernel_service.c b/subsys/shell/modules/kernel_service.c
index 71ff4ab..94940dd 100644
--- a/subsys/shell/modules/kernel_service.c
+++ b/subsys/shell/modules/kernel_service.c
@@ -140,7 +140,12 @@
 
 	shell_print(shell, "Scheduler: %u since last call", sys_clock_elapsed());
 	shell_print(shell, "Threads:");
+
+#ifdef CONFIG_SMP
+	k_thread_foreach_unlocked(shell_tdata_dump, (void *)shell);
+#else
 	k_thread_foreach(shell_tdata_dump, (void *)shell);
+#endif
 	return 0;
 }
 
@@ -184,7 +189,12 @@
 
 	ARG_UNUSED(argc);
 	ARG_UNUSED(argv);
+
+#ifdef CONFIG_SMP
+	k_thread_foreach_unlocked(shell_stack_dump, (void *)shell);
+#else
 	k_thread_foreach(shell_stack_dump, (void *)shell);
+#endif
 
 	/* Placeholder logic for interrupt stack until we have better
 	 * kernel support, including dumping arch-specific exception-related