smf: use get_child_of() for topmost in smf_set_initial()
Replace get_last_of(init_state) with get_child_of(init_state, NULL),
and add a brief comment to avoid relying on a trivial wrapper. Also,
the wrapper name get_last_of() is not very descriptive; using
get_child_of() with an comment makes the intent more explicit.
Signed-off-by: Vladislav Kulikov <vlad_kulikov_c@pm.me>
diff --git a/lib/smf/smf.c b/lib/smf/smf.c
index a46e57b..e84c351 100644
--- a/lib/smf/smf.c
+++ b/lib/smf/smf.c
@@ -51,11 +51,6 @@
}
}
-static const struct smf_state *get_last_of(const struct smf_state *states)
-{
- return get_child_of(states, NULL);
-}
-
/**
* @brief Find the Least Common Ancestor (LCA) of two states,
* that are not ancestors of one another.
@@ -256,7 +251,8 @@
struct internal_ctx *const internal = (void *)&ctx->internal;
ctx->executing = init_state;
- const struct smf_state *topmost = get_last_of(init_state);
+ /* topmost is the root ancestor of init_state, its parent == NULL */
+ const struct smf_state *topmost = get_child_of(init_state, NULL);
/* Execute topmost state entry action, since smf_execute_all_entry_actions()
* doesn't
