scripts: set_assignees.py: Use "size: XS" label for one-liners
Previously, one-line changes were tagged as "Trivial".
The description of the "Trivial" label states:
"Changes that can be reviewed by anyone, i.e. doc changes, minor build
system tweaks, etc.".
Just because a change only affects a single line of code, it does not
mean that it is a trivial change. It may have difficult to understand
implications which require approval of the responsible maintainer.
For this reason, change the label to "size: XS" and let humans judge
if a PR is trivial or not.
Signed-off-by: Martin Jäger <martin@libre.solar>
diff --git a/scripts/set_assignees.py b/scripts/set_assignees.py
index d209193..6797354 100755
--- a/scripts/set_assignees.py
+++ b/scripts/set_assignees.py
@@ -70,15 +70,12 @@
all_areas = set()
fn = list(pr.get_files())
- manifest_change = False
for changed_file in fn:
if changed_file.filename in ['west.yml','submanifests/optional.yaml']:
- manifest_change = True
break
- # one liner PRs should be trivial
- if pr.commits == 1 and (pr.additions <= 1 and pr.deletions <= 1) and not manifest_change:
- labels = {'Trivial'}
+ if pr.commits == 1 and (pr.additions <= 1 and pr.deletions <= 1):
+ labels = {'size: XS'}
if len(fn) > 500:
log(f"Too many files changed ({len(fn)}), skipping....")
