tests: logging: log_api: Remove accidental early return
There was an accidental early return in the test. Spotted by
coverity CID 235986, 236006.
Additionally, test had to be fixed because early returned covered
issues.
Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
diff --git a/tests/subsys/logging/log_api/src/test.inc b/tests/subsys/logging/log_api/src/test.inc
index 99dcc95..eaf8692 100644
--- a/tests/subsys/logging/log_api/src/test.inc
+++ b/tests/subsys/logging/log_api/src/test.inc
@@ -32,7 +32,7 @@
#define TIMESTAMP_INIT_VAL 0
#endif
-MOCK_LOG_BACKEND_DEFINE(backend1, true);
+MOCK_LOG_BACKEND_DEFINE(backend1, false);
MOCK_LOG_BACKEND_DEFINE(backend2, false);
static log_timestamp_t stamp;
@@ -79,6 +79,8 @@
mock_log_backend_reset(&backend1);
mock_log_backend_reset(&backend2);
+ log_backend_enable(&backend1, backend1.cb->ctx, LOG_LEVEL_DBG);
+
if (backend2_enable) {
log_backend_enable(&backend2, backend2.cb->ctx, LOG_LEVEL_DBG);
} else {
@@ -512,14 +514,17 @@
{
log_timestamp_t exp_timestamp = TIMESTAMP_INIT_VAL;
+ log_setup(false);
+
stamp = TIMESTAMP_INIT_VAL;
for (uint32_t i = 0; i < n_msg; i++) {
if (i >= exp_dropped) {
mock_log_backend_record(&backend1, LOG_CURRENT_MODULE_ID(),
CONFIG_LOG_DOMAIN_ID, LOG_LEVEL_INF,
- exp_timestamp++, "dummy");
+ exp_timestamp, "dummy");
}
+ exp_timestamp++;
LOG_INF("dummy");
}
@@ -549,9 +554,6 @@
uint32_t capacity = get_short_msg_capacity();
- return;
- log_setup(false);
-
log_n_messages(capacity, 0);
/* Expect messages dropped when logger more than buffer capacity. */
