commit d8179401b5206130d5afa121dec3867ce8889731
author frei tycho <tfrei@baumer.com> Tue May 14 13:08:17 2024 +0000
committer Alberto Escolar <alberto.escolar.piedras@nordicsemi.no> Fri Jun 14 19:19:29 2024 +0200
tree 9d7134f1f3b1821f943191fd23cf6c9f9bddb9be
parent a2e97405d0ddf4f1fac20b9c5635d923a12317d6

kernel: avoided increments/decrements with side effects

- moved ++/-- before or after the value use

Signed-off-by: frei tycho <tfrei@baumer.com>

kernel/include/priority_q.h

diff --git a/kernel/include/priority_q.h b/kernel/include/priority_q.h
index f744e6c..a2edc26 100644
--- a/kernel/include/priority_q.h
+++ b/kernel/include/priority_q.h
@@ -79,7 +79,8 @@
 {
 	struct k_thread *t;
 
-	thread->base.order_key = pq->next_order_key++;
+	thread->base.order_key = pq->next_order_key;
+	++pq->next_order_key;
 
 	/* Renumber at wraparound.  This is tiny code, and in practice
 	 * will almost never be hit on real systems.  BUT on very
@@ -89,7 +90,8 @@
 	 */
 	if (!pq->next_order_key) {
 		RB_FOR_EACH_CONTAINER(&pq->tree, t, base.qnode_rb) {
-			t->base.order_key = pq->next_order_key++;
+			t->base.order_key = pq->next_order_key;
+			++pq->next_order_key;
 		}
 	}
 

kernel/mempool.c

diff --git a/kernel/mempool.c b/kernel/mempool.c
index c8298f0..d8926c6 100644
--- a/kernel/mempool.c
+++ b/kernel/mempool.c
@@ -46,7 +46,8 @@
 
 	if (ptr != NULL) {
 		heap_ref = ptr;
-		ptr = --heap_ref;
+		--heap_ref;
+		ptr = heap_ref;
 
 		SYS_PORT_TRACING_OBJ_FUNC_ENTER(k_heap_sys, k_free, *heap_ref, heap_ref);