commit fa92bfe3c1a615773aebd2e271a5ed17f3a2d24b
author Leandro Pereira <leandro.pereira@intel.com> Mon Oct 23 12:47:52 2017 -0700
committer Kumar Gala <kumar.gala@gmail.com> Tue Oct 24 08:49:41 2017 +0200
tree da07117d92f71f17698414d6b92b4cfb02435037
parent 5e2303d54e762ddbd46c8a281a1851671ddeefd6

drivers: gpio: gecko: GPIO driver ignores pull-up/pull-down settings

Fixes #4395.

Coverity-ID: 178059
Signed-off-by: Leandro Pereira <leandro.pereira@intel.com>

drivers/gpio/gpio_gecko.c

diff --git a/drivers/gpio/gpio_gecko.c b/drivers/gpio/gpio_gecko.c
index 0574c4d..6a37011 100644
--- a/drivers/gpio/gpio_gecko.c
+++ b/drivers/gpio/gpio_gecko.c
@@ -92,16 +92,15 @@
 	}
 
 	if ((flags & GPIO_DIR_MASK) == GPIO_DIR_IN) {
-
 		if ((flags & GPIO_PUD_MASK) == GPIO_PUD_PULL_UP) {
 			mode = gpioModeInputPull;
 			out = 1; /* pull-up*/
 		} else if ((flags & GPIO_PUD_MASK) == GPIO_PUD_PULL_DOWN) {
 			mode = gpioModeInputPull;
 			/* out = 0 means pull-down*/
+		} else {
+			mode = gpioModeInput;
 		}
-
-		mode = gpioModeInput;
 	} else { /* GPIO_DIR_OUT */
 		mode = gpioModePushPull;
 	}