commit 0db936e0d39a498c9bdcb3ce6b1acbafb86d0db5
author Chris Mumford <cmumford@google.com> Fri Jan 13 13:02:27 2023 +0000
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jan 13 13:02:27 2023 +0000
tree 031262b3b23312ee076653631e19d2b5d92befed
parent 8f0e7b249fca9b83dbf7a4a3c87d3d9474a4f09a

pw_board_led: Minor improvements.

* Using Arduino's LED_BUILTIN instead of hard-coded pin 13.
* Using Toggle instead of explicit call to TurnOn/TurnOff.

Change-Id: I52ee4d72badafac4814dbcdbb06f62f18a0521e1
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/experimental/+/126433
Reviewed-by: Anthony DiGirolamo <tonymd@google.com>
Commit-Queue: Chris Mumford <cmumford@google.com>

applications/blinky/main.cc

diff --git a/applications/blinky/main.cc b/applications/blinky/main.cc
index b6d5171..5690e81 100644
--- a/applications/blinky/main.cc
+++ b/applications/blinky/main.cc
@@ -23,10 +23,7 @@
   while (true) {
     PW_LOG_INFO("Blink %d", i++);
 
-    pw::board_led::TurnOn();
-    pw::spin_delay::WaitMillis(1000);
-
-    pw::board_led::TurnOff();
+    pw::board_led::Toggle();
     pw::spin_delay::WaitMillis(1000);
   }
 

pw_board_led_arduino/led.cc

diff --git a/pw_board_led_arduino/led.cc b/pw_board_led_arduino/led.cc
index 3f9a85f..b515b20 100644
--- a/pw_board_led_arduino/led.cc
+++ b/pw_board_led_arduino/led.cc
@@ -21,23 +21,22 @@
 namespace pw::board_led {
 namespace {
 
-constexpr int kLedPin = 13;
 bool led_on = false;
 
 }  // namespace
 
 void Init() {
-  pinMode(kLedPin, OUTPUT);
+  pinMode(LED_BUILTIN, OUTPUT);
   TurnOff();
 }
 
 void TurnOff() {
-  digitalWrite(kLedPin, LOW);
+  digitalWrite(LED_BUILTIN, LOW);
   led_on = false;
 }
 
 void TurnOn() {
-  digitalWrite(kLedPin, HIGH);
+  digitalWrite(LED_BUILTIN, HIGH);
   led_on = true;
 }