commit bf815fed2167be4b3e62f63ee6c31cddf0132af4
author Rob Mohr <mohrr@google.com> Tue May 18 10:14:41 2021 -0700
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue May 18 19:09:49 2021 +0000
tree c33abd6d35dd6b7cb30ecec8f78332f522c5364e
parent 1fe5051c05bea73b9e00a8cd2f2c2117c0753736

Remove init_* steps from presubmit

Change-Id: Ib710656727aac7dc380ac26210c5ff9d6edc75fe
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/experimental/+/45960
Pigweed-Auto-Submit: Rob Mohr <mohrr@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
Reviewed-by: Armando Montanez <amontanez@google.com>

tools/pigweed_experimental_tools/presubmit_checks.py

diff --git a/tools/pigweed_experimental_tools/presubmit_checks.py b/tools/pigweed_experimental_tools/presubmit_checks.py
index c5635f1..e04eb76 100755
--- a/tools/pigweed_experimental_tools/presubmit_checks.py
+++ b/tools/pigweed_experimental_tools/presubmit_checks.py
@@ -29,7 +29,7 @@
     sys.exit(2)
 
 import pw_presubmit
-from pw_presubmit import build, cli, environment, format_code, git_repo
+from pw_presubmit import build, cli, format_code, git_repo
 from pw_presubmit import python_checks, filter_paths, PresubmitContext
 from pw_presubmit.install_hook import install_hook
 
@@ -52,27 +52,6 @@
     PROJECT_ROOT / 'third_party' / 'nanopb',
 )
 
-
-#
-# Initialization
-#
-def init_cipd(ctx: PresubmitContext):
-    """Initialize CIPD for project dependencies."""
-    environment.init_cipd(PIGWEED_ROOT, ctx.output_dir)
-
-
-def init_virtualenv(ctx: PresubmitContext):
-    """Initialize a virtual environment to run presubmits."""
-    environment.init_virtualenv(
-        PIGWEED_ROOT,
-        ctx.output_dir,
-        gn_targets=(
-            f'{ctx.root}#:python.install',
-            f'{ctx.root}/third_party/pigweed#:python.install',
-            f'{ctx.root}/third_party/pigweed#:target_support_packages.install',
-        ))
-
-
 # Rerun the build if files with these extensions change.
 _BUILD_EXTENSIONS = frozenset(
     ['.rst', '.gn', '.gni', *format_code.C_FORMAT.extensions])
@@ -125,9 +104,6 @@
     format_code.presubmit_checks(exclude=PATH_EXCLUSIONS),
 )
 FULL = (
-    # Initialize an environment for running presubmit checks.
-    init_cipd,
-    init_virtualenv,
     pragma_once,
     QUICK,  # Add all checks from the 'quick' program
     # Use the upstream Python checks, with custom path filters applied.