commit 0029e1e649e3ade6ebea7b936be06b3d02b4a688
author Rob Mohr <mohrr@google.com> Wed Sep 15 13:42:19 2021 -0700
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Sep 16 01:45:14 2021 +0000
tree 88101da054790cdb23fac4026bf879ff38eb7e6e
parent 217b47a62c996a2d6daa3e2e2a3e18dffdbd722f

pw_presubmit: Add --check to Python gn calls

Change-Id: I590dcd0f0a26b9f6c80b4a0b61966223c48904dc
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/61120
Reviewed-by: Armando Montanez <amontanez@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
Pigweed-Auto-Submit: Rob Mohr <mohrr@google.com>

pw_presubmit/py/pw_presubmit/python_checks.py

diff --git a/pw_presubmit/py/pw_presubmit/python_checks.py b/pw_presubmit/py/pw_presubmit/python_checks.py
index f793fec..051d033 100644
--- a/pw_presubmit/py/pw_presubmit/python_checks.py
+++ b/pw_presubmit/py/pw_presubmit/python_checks.py
@@ -37,17 +37,15 @@
 _PYTHON_EXTENSIONS = ('.py', '.gn', '.gni')
 
 
-# TODO(mohrr) Remove gn_check=False when it passes for all downstream projects.
 @filter_paths(endswith=_PYTHON_EXTENSIONS)
 def gn_python_check(ctx: PresubmitContext):
-    build.gn_gen(ctx.root, ctx.output_dir, gn_check=False)
+    build.gn_gen(ctx.root, ctx.output_dir)
     build.ninja(ctx.output_dir, 'python.tests', 'python.lint')
 
 
-# TODO(mohrr) Remove gn_check=False when it passes for all downstream projects.
 @filter_paths(endswith=_PYTHON_EXTENSIONS)
 def gn_python_lint(ctx: pw_presubmit.PresubmitContext) -> None:
-    build.gn_gen(ctx.root, ctx.output_dir, gn_check=False)
+    build.gn_gen(ctx.root, ctx.output_dir)
     build.ninja(ctx.output_dir, 'python.lint')