commit 0ab1d3c64d5e6c62877632aa661b5fd0052678cd
author Rob Mohr <mohrr@google.com> Thu Sep 09 07:23:41 2021 -0700
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Sep 09 19:05:23 2021 +0000
tree 4b846b7a4a81965d99faa74d1a8d8f514bb1bcd5
parent cd66a7460905b2905769acc3c80a0dd3d7b4a856

pw_cli: Ignore environment when testing envparse

Explicitly set error_on_unrecognized=True because the default is to fall
back on the environment which could result in different behavior.

This is needed for pwrev/57502 to pass CQ.

Change-Id: Id2b94ae6370b695b283f825bb57af6caa75b7b6e
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/60380
Pigweed-Auto-Submit: Rob Mohr <mohrr@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
Reviewed-by: Wyatt Hepler <hepler@google.com>

pw_cli/py/envparse_test.py

diff --git a/pw_cli/py/envparse_test.py b/pw_cli/py/envparse_test.py
index dfa3c59..cbeb332 100644
--- a/pw_cli/py/envparse_test.py
+++ b/pw_cli/py/envparse_test.py
@@ -38,7 +38,7 @@
             'ReVeRsE': 'pigweed',
         }
 
-        self.parser = envparse.EnvironmentParser()
+        self.parser = envparse.EnvironmentParser(error_on_unrecognized=True)
         self.parser.add_var('PATH')
         self.parser.add_var('FOO', type=int)
         self.parser.add_var('BAR', type=bool)
@@ -100,7 +100,8 @@
         }
 
     def test_parse_unrecognized_variable(self):
-        parser = envparse.EnvironmentParser(prefix='PW_')
+        parser = envparse.EnvironmentParser(prefix='PW_',
+                                            error_on_unrecognized=True)
         parser.add_var('PW_FOO')
         parser.add_var('PW_BAR')
 
@@ -108,14 +109,16 @@
             parser.parse_env(env=self.raw_env)
 
     def test_parse_unrecognized_but_allowed_suffix(self):
-        parser = envparse.EnvironmentParser(prefix='PW_')
+        parser = envparse.EnvironmentParser(prefix='PW_',
+                                            error_on_unrecognized=True)
         parser.add_allowed_suffix('_ALLOWED_SUFFIX')
 
         env = parser.parse_env(env={'PW_FOO_ALLOWED_SUFFIX': '001'})
         self.assertEqual(env.PW_FOO_ALLOWED_SUFFIX, '001')
 
     def test_parse_allowed_suffix_but_not_suffix(self):
-        parser = envparse.EnvironmentParser(prefix='PW_')
+        parser = envparse.EnvironmentParser(prefix='PW_',
+                                            error_on_unrecognized=True)
         parser.add_allowed_suffix('_ALLOWED_SUFFIX')
 
         with self.assertRaises(ValueError):
@@ -132,7 +135,8 @@
         self.assertEqual(env.PW_BAR, self.raw_env['PW_BAR'])
 
     def test_add_var_without_prefix(self):
-        parser = envparse.EnvironmentParser(prefix='PW_')
+        parser = envparse.EnvironmentParser(prefix='PW_',
+                                            error_on_unrecognized=True)
         with self.assertRaises(ValueError):
             parser.add_var('FOO')