commit 0bf1eb95496db6eac66c6d547060f8a09cee3161
author Wyatt Hepler <hepler@google.com> Fri Jan 07 08:48:59 2022 -0800
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jan 07 17:58:05 2022 +0000
tree 9fdba890c019df9870a919291056bec960726eb5
parent 16edd4074b2d6a5728deb7e6727ef056863339fd

pw_multisink: Move call out of PW_DCHECK_OK

PW_DCHECK statements are not executed when debug asserts are disabled.

Change-Id: I8e67906b0495025428560770504535868b99e8f6
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/77503
Pigweed-Auto-Submit: Wyatt Hepler <hepler@google.com>
Reviewed-by: Armando Montanez <amontanez@google.com>
Commit-Queue: Wyatt Hepler <hepler@google.com>
Reviewed-by: Prashanth Swaminathan <prashanthsw@google.com>

pw_multisink/multisink.cc

diff --git a/pw_multisink/multisink.cc b/pw_multisink/multisink.cc
index a93cf2b..d6fe139 100644
--- a/pw_multisink/multisink.cc
+++ b/pw_multisink/multisink.cc
@@ -29,7 +29,8 @@
 
 void MultiSink::HandleEntry(ConstByteSpan entry) {
   std::lock_guard lock(lock_);
-  PW_DCHECK_OK(ring_buffer_.PushBack(entry, sequence_id_++));
+  const Status push_back_status = ring_buffer_.PushBack(entry, sequence_id_++);
+  PW_DCHECK_OK(push_back_status);
   NotifyListeners();
 }