| commit | 13543886691e2010eec3539bcb3552e6387b9719 | [log] [tgz] |
|---|---|---|
| author | Rob Mohr <mohrr@google.com> | Thu May 20 15:06:16 2021 -0700 |
| committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu May 20 22:30:23 2021 +0000 |
| tree | bec337816c0a169b7d3baaa5b7dd77717868c76a | |
| parent | 99feb0bea79d3d4be8c5f3a70b1324fad5743912 [diff] |
pw_presubmit: Handle banned words with underscores
Handle underscores around banned words. Before this CL "${BANNED}" was
blocked but "_${BANNED}_" was not.
Change-Id: Ieb4f6578036930a33669cf11007a245b7c89b751
Bug: 386
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/46342
Pigweed-Auto-Submit: Rob Mohr <mohrr@google.com>
Reviewed-by: Armando Montanez <amontanez@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
diff --git a/pw_presubmit/py/pw_presubmit/banned_words.py b/pw_presubmit/py/pw_presubmit/banned_words.py index eae763b..f0812ac 100644 --- a/pw_presubmit/py/pw_presubmit/banned_words.py +++ b/pw_presubmit/py/pw_presubmit/banned_words.py
@@ -66,7 +66,7 @@ _ = re.compile(word) return re.compile( - r"\b({})(\b|e?[sd]\b)".format('|'.join(all_words)), + r"(\b|_)({})(\b|_|e?[sd]_?\b)".format('|'.join(all_words)), re.IGNORECASE, )