commit 16edd4074b2d6a5728deb7e6727ef056863339fd
author Wyatt Hepler <hepler@google.com> Thu Jan 06 17:25:39 2022 -0800
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jan 07 01:49:15 2022 +0000
tree 6b718bc085a9e14f4979bb81e0442046dfbf56a0
parent 89147b391efa6878cbca1976f12c3f9e3d854214

pw_rpc: Fix double mutex unlock

The RPC lock was unlocked by both the lock guard and an unlock call.
This replaces the lock guard with a lock call.

Change-Id: I4aea1a4d51c6696ec303ce8d57372d5b70af3c16
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/77304
Pigweed-Auto-Submit: Wyatt Hepler <hepler@google.com>
Reviewed-by: Alexei Frolov <frolv@google.com>
Commit-Queue: Wyatt Hepler <hepler@google.com>

pw_rpc/endpoint.cc

diff --git a/pw_rpc/endpoint.cc b/pw_rpc/endpoint.cc
index 9edec4b..9982ff9 100644
--- a/pw_rpc/endpoint.cc
+++ b/pw_rpc/endpoint.cc
@@ -61,7 +61,7 @@
 }
 
 void Endpoint::RegisterCall(Call& call) {
-  LockGuard lock(rpc_lock());
+  rpc_lock().lock();
 
   Call* const existing_call = FindCallById(
       call.channel_id_locked(), call.service_id(), call.method_id());