pw_bloat: Don't put rebased paths in inputs
It's not needed to use rebase_path() for paths used by GN builtins - GN
always processes paths relative to the current build file or relative to
the GN --root.
Use of rebase_path should be limited to arguments passed to external
commands.
This was causing docs to fail to build due to putting build directory
relative paths in inputs (when it should be build file relative).
No-Docs-Update-Reason: bug fix
Change-Id: I994ddaaba44539360e693788bc80f311a7c44166
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/48641
Reviewed-by: Rob Mohr <mohrr@google.com>
Commit-Queue: Michael Spang <spang@google.com>
diff --git a/pw_bloat/bloat.gni b/pw_bloat/bloat.gni
index 6d79cfb..a22a092 100644
--- a/pw_bloat/bloat.gni
+++ b/pw_bloat/bloat.gni
@@ -116,10 +116,9 @@
# Allow each binary to override the global bloaty config.
if (defined(binary.bloaty_config)) {
- _bloaty_configs += [ rebase_path(binary.bloaty_config, root_build_dir) ]
+ _bloaty_configs += [ binary.bloaty_config ]
} else {
- _bloaty_configs +=
- [ rebase_path(pw_bloat_BLOATY_CONFIG, root_build_dir) ]
+ _bloaty_configs += [ pw_bloat_BLOATY_CONFIG ]
}
_binary_path += ";" + "<TARGET_FILE($_binary_base)>"
@@ -130,7 +129,7 @@
_bloat_script_args = [
"--bloaty-config",
- string_join(";", _bloaty_configs),
+ string_join(";", rebase_path(_bloaty_configs, root_build_dir)),
"--out-dir",
rebase_path(target_gen_dir, root_build_dir),
"--target",
