blob: dad5362818b7436cb53c1e4782cdb04efc5a9bf7 [file] [log] [blame]
# Copyright 2020 The Pigweed Authors
# Licensed under the Apache License, Version 2.0 (the "License"); you may not
# use this file except in compliance with the License. You may obtain a copy of
# the License at
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations under
# the License.
"""Tools for running presubmit checks in a Git repository.
Presubmit checks are defined as a function or other callable. The function may
take either no arguments or a list of the paths on which to run. Presubmit
checks communicate failure by raising any exception.
For example, either of these functions may be used as presubmit checks:
def file_contains_ni(ctx: PresubmitContext):
for path in ctx.paths:
with open(path) as file:
contents =
if 'ni' not in contents and 'nee' not in contents:
raise PresumitFailure('Files must say "ni"!', path=path)
def run_the_build():['make', 'release'], check=True)
Presubmit checks that accept a list of paths may use the filter_paths decorator
to automatically filter the paths list for file types they care about. See the
pragma_once function for an example.
See for an example of how to define presubmit checks.
from __future__ import annotations
import collections
import contextlib
import dataclasses
import enum
from inspect import Parameter, signature
import itertools
import logging
import os
from pathlib import Path
import re
import subprocess
import time
from typing import (Callable, Collection, Dict, Iterable, Iterator, List,
Optional, Pattern, Sequence, Set, Tuple, Union)
import pw_cli.color
import pw_cli.env
from pw_presubmit import git_repo, tools
from import plural
_LOG: logging.Logger = logging.getLogger(__name__)
_COLOR = pw_cli.color.colors()
_SUMMARY_BOX = '══╦╗ ║║══╩╝'
_CHECK_UPPER = '━━━┓ '
_CHECK_LOWER = ' ━━━┛'
WIDTH = 80
_LEFT = 7
_RIGHT = 11
def _title(msg, style=_SUMMARY_BOX) -> str:
msg = f' {msg} '.center(WIDTH - 2)
return tools.make_box('^').format(*style, section1=msg, width1=len(msg))
def _format_time(time_s: float) -> str:
minutes, seconds = divmod(time_s, 60)
if minutes < 60:
return f' {int(minutes)}:{seconds:04.1f}'
hours, minutes = divmod(minutes, 60)
return f'{int(hours):d}:{int(minutes):02}:{int(seconds):02}'
def _box(style, left, middle, right, box=tools.make_box('><>')) -> str:
return box.format(*style,
section1=left + ('' if left.endswith(' ') else ' '),
section2=' ' + middle,
width2=WIDTH - _LEFT - _RIGHT - 4,
section3=right + ' ',
class PresubmitFailure(Exception):
"""Optional exception to use for presubmit failures."""
def __init__(self, description: str = '', path: Path = None):
super().__init__(f'{path}: {description}' if path else description)
class _Result(enum.Enum):
PASS = 'PASSED' # Check completed successfully.
FAIL = 'FAILED' # Check failed.
CANCEL = 'CANCEL' # Check didn't complete.
def colorized(self, width: int, invert: bool = False) -> str:
if self is _Result.PASS:
color = _COLOR.black_on_green if invert else
elif self is _Result.FAIL:
color = _COLOR.black_on_red if invert else
elif self is _Result.CANCEL:
color = _COLOR.yellow
color = lambda value: value
padding = (width - len(self.value)) // 2 * ' '
return padding + color(self.value) + padding
class Program(
"""A sequence of presubmit checks; basically a tuple with a name."""
def __init__(self, name: str, steps: Iterable[Callable]): = name
self._steps = tuple({s: None for s in tools.flatten(steps)})
def __getitem__(self, i):
return self._steps[i]
def __len__(self):
return len(self._steps)
def __str__(self):
def title(self):
return f'{ if else ""} presubmit checks'.strip()
class Programs(
"""A mapping of presubmit check programs.
Use is optional. Helpful when managing multiple presubmit check programs.
def __init__(self, **programs: Sequence):
"""Initializes a name: program mapping from the provided keyword args.
A program is a sequence of presubmit check functions. The sequence may
contain nested sequences, which are flattened.
self._programs: Dict[str, Program] = {
name: Program(name, checks)
for name, checks in programs.items()
def all_steps(self) -> Dict[str, Callable]:
return {c.__name__: c for c in itertools.chain(*self.values())}
def __getitem__(self, item: str) -> Program:
return self._programs[item]
def __iter__(self) -> Iterator[str]:
return iter(self._programs)
def __len__(self) -> int:
return len(self._programs)
class LuciContext:
"""LUCI-specific information about the environment."""
buildbucket_id: int
build_number: int
project: str
bucket: str
builder: str
swarming_task_id: str
def create_from_environment():
luci_vars = [
if any(x for x in luci_vars if x not in os.environ):
return None
project, bucket, builder = os.environ['BUILDBUCKET_NAME'].split(':')
bbid: int = 0
bbid = int(os.environ['BUILDBUCKET_ID'])
except ValueError:
return LuciContext(
class PresubmitContext:
"""Context passed into presubmit checks."""
root: Path
repos: Tuple[Path, ...]
output_dir: Path
paths: Tuple[Path, ...]
package_root: Path
luci: Optional[LuciContext]
override_gn_args: Dict[str, str]
num_jobs: Optional[int] = None
continue_after_build_error: bool = False
_failed: bool = False
def failed(self) -> bool:
return self._failed
def fail(self, description: str, path: Path = None):
"""Add a failure to this presubmit step.
If this is called at least once the step fails, but not immediately—the
check is free to continue and possibly call this method again.
_LOG.warning('%s', PresubmitFailure(description, path))
self._failed = True
class FileFilter:
"""Allows checking if a path matches a series of filters.
Positive filters (e.g. the file name matches a regex) and negative filters
(path does not match a regular expression) may be applied.
_StrOrPattern = Union[Pattern, str]
def __init__(
exclude: Iterable[_StrOrPattern] = (),
endswith: Iterable[str] = (),
name: Iterable[_StrOrPattern] = (),
suffix: Iterable[str] = ()
) -> None:
"""Creates a FileFilter with the provided filters.
endswith: True if the end of the path is equal to any of the passed
exclude: If any of the passed regular expresion match return False.
This overrides and other matches.
name: Regexs to match with file names( True if
the resulting regex matches the entire file name.
suffix: True if final suffix (as determined by pathlib.Path) is
matched by any of the passed str.
self.exclude = tuple(re.compile(i) for i in exclude)
self.endswith = tuple(endswith) = tuple(re.compile(i) for i in name)
self.suffix = tuple(suffix)
def matches(self, path: Union[str, Path]) -> bool:
"""Returns true if the path matches any filter but not an exclude.
If no positive filters are specified, any paths that do not match a
negative filter are considered to match.
If 'path' is a Path object it is rendered as a posix path (i.e.
using "/" as the path seperator) before testing with 'exclude' and
posix_path = path.as_posix() if isinstance(path, Path) else path
if any(bool( for exp in self.exclude):
return False
# If there are no positive filters set, accept all paths.
no_filters = not self.endswith and not and not self.suffix
path_obj = Path(path)
return (no_filters or path_obj.suffix in self.suffix
or any(regex.fullmatch( for regex in
or any(posix_path.endswith(end) for end in self.endswith))
def apply_to_check(self, always_run: bool = False) -> Callable:
def wrapper(func: Callable) -> Check:
return Check(check_function=func,
return wrapper
def _print_ui(*args) -> None:
"""Prints to stdout and flushes to stay in sync with logs on stderr."""
print(*args, flush=True)
class Presubmit:
"""Runs a series of presubmit checks on a list of files."""
def __init__(self, root: Path, repos: Sequence[Path],
output_directory: Path, paths: Sequence[Path],
package_root: Path, override_gn_args: Dict[str, str],
continue_after_build_error: bool):
self._root = root.resolve()
self._repos = tuple(repos)
self._output_directory = output_directory.resolve()
self._paths = tuple(paths)
self._relative_paths = tuple(
tools.relative_paths(self._paths, self._root))
self._package_root = package_root.resolve()
self._override_gn_args = override_gn_args
self._continue_after_build_error = continue_after_build_error
def run(self, program: Program, keep_going: bool = False) -> bool:
"""Executes a series of presubmit checks on the paths."""
checks = self.apply_filters(program)
_LOG.debug('Running %s for %s', program.title(),
_print_ui(_title(f'{}: {program.title()}'))'%d of %d checks apply to %s in %s', len(checks),
len(program), plural(self._paths, 'file'), self._root)
for line in tools.file_summary(self._relative_paths):
if not self._paths:
_print_ui(_COLOR.yellow('No files are being checked!'))
_LOG.debug('Checks:\n%s', '\n'.join( for c, _ in checks))
start_time: float = time.time()
passed, failed, skipped = self._execute_checks(checks, keep_going)
self._log_summary(time.time() - start_time, passed, failed, skipped)
return not failed and not skipped
def apply_filters(
program: Sequence[Callable]) -> List[Tuple[Check, Sequence[Path]]]:
"""Returns list of (check, paths) for checks that should run."""
checks = [c if isinstance(c, Check) else Check(c) for c in program]
filter_to_checks: Dict[FileFilter,
List[Check]] = collections.defaultdict(list)
for check in checks:
check_to_paths = self._map_checks_to_paths(filter_to_checks)
return [(c, check_to_paths[c]) for c in checks if c in check_to_paths]
def _map_checks_to_paths(
self, filter_to_checks: Dict[FileFilter, List[Check]]
) -> Dict[Check, Sequence[Path]]:
checks_to_paths: Dict[Check, Sequence[Path]] = {}
posix_paths = tuple(p.as_posix() for p in self._relative_paths)
for filt, checks in filter_to_checks.items():
filtered_paths = tuple(
path for path, filter_path in zip(self._paths, posix_paths)
if filt.matches(filter_path))
for check in checks:
if filtered_paths or check.always_run:
checks_to_paths[check] = filtered_paths
_LOG.debug('Skipping "%s": no relevant files',
return checks_to_paths
def _log_summary(self, time_s: float, passed: int, failed: int,
skipped: int) -> None:
summary_items = []
if passed:
summary_items.append(f'{passed} passed')
if failed:
summary_items.append(f'{failed} failed')
if skipped:
summary_items.append(f'{skipped} not run')
summary = ', '.join(summary_items) or 'nothing was done'
result = _Result.FAIL if failed or skipped else _Result.PASS
total = passed + failed + skipped
_LOG.debug('Finished running %d checks on %s in %.1f s', total,
plural(self._paths, 'file'), time_s)
_LOG.debug('Presubmit checks %s: %s', result.value, summary)
_SUMMARY_BOX, result.colorized(_LEFT, invert=True),
f'{total} checks on {plural(self._paths, "file")}: {summary}',
def _create_presubmit_context( # pylint: disable=no-self-use
self, **kwargs):
"""Create a PresubmitContext. Override if needed in subclasses."""
return PresubmitContext(**kwargs)
def _context(self, name: str, paths: Tuple[Path, ...]):
# There are many characters banned from filenames on Windows. To
# simplify things, just strip everything that's not a letter, digit,
# or underscore.
sanitized_name = re.sub(r'[\W_]+', '_', name).lower()
output_directory = self._output_directory.joinpath(sanitized_name)
os.makedirs(output_directory, exist_ok=True)
handler = logging.FileHandler(output_directory.joinpath('step.log'),
yield self._create_presubmit_context(
def _execute_checks(self, program,
keep_going: bool) -> Tuple[int, int, int]:
"""Runs presubmit checks; returns (passed, failed, skipped) lists."""
passed = failed = 0
for i, (check, paths) in enumerate(program, 1):
with self._context(, paths) as ctx:
result =, i, len(program))
if result is _Result.PASS:
passed += 1
elif result is _Result.CANCEL:
failed += 1
if not keep_going:
return passed, failed, len(program) - passed - failed
def _process_pathspecs(repos: Iterable[Path],
pathspecs: Iterable[str]) -> Dict[Path, List[str]]:
pathspecs_by_repo: Dict[Path, List[str]] = {repo: [] for repo in repos}
repos_with_paths: Set[Path] = set()
for pathspec in pathspecs:
# If the pathspec is a path to an existing file, only use it for the
# repo it is in.
if os.path.exists(pathspec):
# Raise an exception if the path exists but is not in a known repo.
repo = git_repo.within_repo(pathspec)
if repo not in pathspecs_by_repo:
raise ValueError(
f'{pathspec} is not in a Git repository in this presubmit')
# Make the path relative to the repo's root.
pathspecs_by_repo[repo].append(os.path.relpath(pathspec, repo))
# Pathspecs that are not paths (e.g. '*.h') are used for all repos.
for patterns in pathspecs_by_repo.values():
# If any paths were specified, only search for paths in those repos.
if repos_with_paths:
for repo in set(pathspecs_by_repo) - repos_with_paths:
del pathspecs_by_repo[repo]
return pathspecs_by_repo
def run( # pylint: disable=too-many-arguments
program: Sequence[Callable],
root: Path,
repos: Collection[Path] = (),
base: Optional[str] = None,
paths: Sequence[str] = (),
exclude: Sequence[Pattern] = (),
output_directory: Optional[Path] = None,
package_root: Path = None,
only_list_steps: bool = False,
override_gn_args: Sequence[Tuple[str, str]] = (),
keep_going: bool = False,
continue_after_build_error: bool = False,
presubmit_class: type = Presubmit) -> bool:
"""Lists files in the current Git repo and runs a Presubmit with them.
This changes the directory to the root of the Git repository after listing
paths, so all presubmit checks can assume they run from there.
The paths argument contains Git pathspecs. If no pathspecs are provided, all
paths in all repos are included. If paths to files or directories are
provided, only files within those repositories are searched. Patterns are
searched across all repositories. For example, if the pathspecs "my_module/"
and "*.h", paths under "my_module/" in the containing repo and paths in all
repos matching "*.h" will be included in the presubmit.
program: list of presubmit check functions to run
root: root path of the project
repos: paths to the roots of Git repositories to check
name: name to use to refer to this presubmit check run
base: optional base Git commit to list files against
paths: optional list of Git pathspecs to run the checks against
exclude: regular expressions for Posix-style paths to exclude
output_directory: where to place output files
package_root: where to place package files
only_list_steps: print step names instead of running them
override_gn_args: additional GN args to set on steps
keep_going: continue running presubmit steps after a step fails
continue_after_build_error: continue building if a build step fails
presubmit_class: class to use to run Presubmits, should inherit from
Presubmit class above
True if all presubmit checks succeeded
repos = [repo.resolve() for repo in repos]
non_empty_repos = []
for repo in repos:
if list(repo.iterdir()):
if git_repo.root(repo) != repo:
raise ValueError(
f'{repo} is not the root of a Git repo; '
'presubmit checks must be run from a Git repo')
repos = non_empty_repos
pathspecs_by_repo = _process_pathspecs(repos, paths)
files: List[Path] = []
for repo, pathspecs in pathspecs_by_repo.items():
files += tools.exclude_paths(
exclude, git_repo.list_files(base, pathspecs, repo), root)
'Checking %s',
git_repo.describe_files(repo, repo, base, pathspecs, exclude,
if output_directory is None:
output_directory = root / '.presubmit'
if package_root is None:
package_root = output_directory / 'packages'
presubmit = presubmit_class(
override_gn_args=dict(override_gn_args or {}),
if only_list_steps:
for check, _ in presubmit.apply_filters(program):
return True
if not isinstance(program, Program):
program = Program('', program)
return, keep_going)
def _make_str_tuple(value: Union[Iterable[str], str]) -> Tuple[str, ...]:
return tuple([value] if isinstance(value, str) else value)
class Check:
"""Wraps a presubmit check function.
This class consolidates the logic for running and logging a presubmit check.
It also supports filtering the paths passed to the presubmit check.
def __init__(self,
check_function: Callable,
path_filter: FileFilter = FileFilter(),
always_run: bool = True) -> None:
self._check: Callable = check_function
self.filter = path_filter
self.always_run: bool = always_run
# Since Check wraps a presubmit function, adopt that function's name.
self.__name__ = self._check.__name__
def with_filter(
endswith: Iterable[str] = (),
exclude: Iterable[Union[Pattern[str], str]] = ()
) -> Check:
return self.with_file_filter(
FileFilter(endswith=_make_str_tuple(endswith), exclude=exclude))
def with_file_filter(self, file_filter: FileFilter) -> Check:
return Check(check_function=self._check,
def name(self):
return self.__name__
def run(self, ctx: PresubmitContext, count: int, total: int) -> _Result:
"""Runs the presubmit check on the provided paths."""
_box(_CHECK_UPPER, f'{count}/{total}',,
plural(ctx.paths, "file")))
_LOG.debug('[%d/%d] Running %s on %s', count, total,,
plural(ctx.paths, "file"))
start_time_s = time.time()
result = self._call_function(ctx)
time_str = _format_time(time.time() - start_time_s)
_LOG.debug('%s %s',, result.value)
_box(_CHECK_LOWER, result.colorized(_LEFT),, time_str))
_LOG.debug('%s duration:%s',, time_str)
return result
def _call_function(self, ctx: PresubmitContext) -> _Result:
except PresubmitFailure as failure:
if str(failure):
_LOG.warning('%s', failure)
return _Result.FAIL
except Exception as failure: # pylint: disable=broad-except
_LOG.exception('Presubmit check %s failed!',
return _Result.FAIL
except KeyboardInterrupt:
return _Result.CANCEL
if ctx.failed:
return _Result.FAIL
return _Result.PASS
def __call__(self, ctx: PresubmitContext, *args, **kwargs):
"""Calling a Check calls its underlying function directly.
This makes it possible to call functions wrapped by @filter_paths. The
prior filters are ignored, so new filters may be applied.
return self._check(ctx, *args, **kwargs)
def _required_args(function: Callable) -> Iterable[Parameter]:
"""Returns the required arguments for a function."""
optional_types = Parameter.VAR_POSITIONAL, Parameter.VAR_KEYWORD
for param in signature(function).parameters.values():
if param.default is param.empty and param.kind not in optional_types:
yield param
def _ensure_is_valid_presubmit_check_function(check: Callable) -> None:
"""Checks if a Callable can be used as a presubmit check."""
required_args = tuple(_required_args(check))
except (TypeError, ValueError):
raise TypeError('Presubmit checks must be callable, but '
f'{check!r} is a {type(check).__name__}')
if len(required_args) != 1:
raise TypeError(
f'Presubmit check functions must have exactly one required '
f'positional argument (the PresubmitContext), but '
f'{check.__name__} has {len(required_args)} required arguments' +
(f' ({", ".join( for a in required_args)})'
if required_args else ''))
def filter_paths(*,
endswith: Iterable[str] = (),
exclude: Iterable[Union[Pattern[str], str]] = (),
file_filter: FileFilter = None,
always_run: bool = False) -> Callable[[Callable], Check]:
"""Decorator for filtering the paths list for a presubmit check function.
Path filters only apply when the function is used as a presubmit check.
Filters are ignored when the functions are called directly. This makes it
possible to reuse functions wrapped in @filter_paths in other presubmit
checks, potentially with different path filtering rules.
endswith: str or iterable of path endings to include
exclude: regular expressions of paths to exclude
file_filter: FileFilter used to select files
always_run: Run check even when no files match
a wrapped version of the presubmit function
if file_filter:
real_file_filter = file_filter
if endswith or exclude:
raise ValueError('Must specify either file_filter or '
'endswith/exclude args, not both')
# TODO(b/238426363): Remove these arguments and use FileFilter only.
real_file_filter = FileFilter(endswith=_make_str_tuple(endswith),
def filter_paths_for_function(function: Callable):
return Check(function, real_file_filter, always_run=always_run)
return filter_paths_for_function
def call(*args, **kwargs) -> None:
"""Optional subprocess wrapper that causes a PresubmitFailure on errors."""
attributes, command = tools.format_command(args, kwargs)
_LOG.debug('[RUN] %s\n%s', attributes, command)
env = pw_cli.env.pigweed_environment()
kwargs['stdout'] = subprocess.PIPE
kwargs['stderr'] = subprocess.STDOUT
process = subprocess.Popen(args, **kwargs)
assert process.stdout
while True:
line = process.stdout.readline().decode(errors='backslashreplace')
if not line:
stdout, _ = process.communicate()
logfunc = _LOG.warning if process.returncode else _LOG.debug
logfunc('[FINISHED]\n%s', command)
logfunc('[RESULT] %s with return code %d',
'Failed' if process.returncode else 'Passed', process.returncode)
if stdout:
logfunc('[OUTPUT]\n%s', stdout.decode(errors='backslashreplace'))
if process.returncode:
raise PresubmitFailure