commit 3950de4195d7606a741e7d0c89e9d01058900652
author Dennis Kormalev <denk@google.com> Tue Jun 21 14:18:57 2022 +0000
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jun 21 17:33:34 2022 +0000
tree 2c87c7dca605e906ac06ec5c3bd468c6d50b3d7f
parent e89e39267e07ab5a07ad1c801f471946f3792379

pw_bytes: Use c++20-friendly pointer operations on spans

With C++20 enabled pigweed uses std::span from the standard library.
It doesn't specify they iterator type and it is not always possible to
cast it to the pointer directly. We need to use .data() instead.

Change-Id: I7ae7c5a7355de14e0cc13fce18e575c22dfdac62
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/98903
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
Pigweed-Auto-Submit: Dennis Kormalev <denk@google.com>
Reviewed-by: Rob Mohr <mohrr@google.com>

pw_bytes/byte_builder.cc

diff --git a/pw_bytes/byte_builder.cc b/pw_bytes/byte_builder.cc
index 96552a6..9c082fd 100644
--- a/pw_bytes/byte_builder.cc
+++ b/pw_bytes/byte_builder.cc
@@ -17,13 +17,13 @@
 namespace pw {
 
 ByteBuilder& ByteBuilder::append(size_t count, std::byte b) {
-  std::byte* const append_destination = buffer_.begin() + size_;
+  std::byte* const append_destination = buffer_.data() + size_;
   std::fill_n(append_destination, ResizeForAppend(count), b);
   return *this;
 }
 
 ByteBuilder& ByteBuilder::append(const void* bytes, size_t count) {
-  std::byte* const append_destination = buffer_.begin() + size_;
+  std::byte* const append_destination = buffer_.data() + size_;
   std::copy_n(static_cast<const std::byte*>(bytes),
               ResizeForAppend(count),
               append_destination);