pw_sync: Make thread_notification_inline publicly depend on pw_assert
As pw_assert is depended on in the public header, this dep should be
public to prevent users (who may not depend on or include pw_assert
themselves) needing to add pw_assert as a dependency.
Change-Id: I92c65856252e4a09d70e919261dd7fbf1701e7c3
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/111270
Pigweed-Auto-Submit: Taylor Cramer <cramertj@google.com>
Reviewed-by: Wyatt Hepler <hepler@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
diff --git a/pw_sync_freertos/BUILD.bazel b/pw_sync_freertos/BUILD.bazel
index 48a66a8..991bd78 100644
--- a/pw_sync_freertos/BUILD.bazel
+++ b/pw_sync_freertos/BUILD.bazel
@@ -152,6 +152,7 @@
"//pw_build/constraints/rtos:freertos",
],
deps = [
+ "//pw_assert",
# TODO(b/234876414): This should depend on FreeRTOS but our third parties
# currently do not have Bazel support.
"//pw_interrupt:context",
diff --git a/pw_sync_freertos/BUILD.gn b/pw_sync_freertos/BUILD.gn
index 1f2fc0c..466d94a 100644
--- a/pw_sync_freertos/BUILD.gn
+++ b/pw_sync_freertos/BUILD.gn
@@ -173,15 +173,13 @@
"public_overrides/thread_notification/pw_sync_backend/thread_notification_native.h",
]
public_deps = [
+ "$dir_pw_assert",
"$dir_pw_interrupt:context",
"$dir_pw_sync:thread_notification.facade",
"$dir_pw_third_party/freertos",
]
sources = [ "thread_notification.cc" ]
- deps = [
- ":config",
- dir_pw_assert,
- ]
+ deps = [ ":config" ]
}
config("public_overrides_timed_thread_notification_include_path") {
diff --git a/pw_sync_freertos/CMakeLists.txt b/pw_sync_freertos/CMakeLists.txt
index 6139c39..b081963 100644
--- a/pw_sync_freertos/CMakeLists.txt
+++ b/pw_sync_freertos/CMakeLists.txt
@@ -124,12 +124,12 @@
public
public_overrides/thread_notification
PUBLIC_DEPS
+ pw_assert
pw_interrupt.context
pw_third_party.freertos
SOURCES
thread_notification.cc
PRIVATE_DEPS
- pw_assert
pw_sync_freertos.config
)