commit 5c9007f0b81d7612501423c7dcd6594af7312785
author karthik bharadwaj <karthikmb@google.com> Wed Jun 15 12:50:30 2022 -0700
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Jun 16 20:52:47 2022 +0000
tree 8a9927c145b2c27b800a3aa33894233917c33395
parent 82e526ca40e899d5ebeb9cd1028a618f75961ca9

pw_tokenizer: Fix decode string size type

Clang is unnecessarily strict with its narrowing rules, add a cast
to size_t to avoid using a '-Wno-c++11-narrowing', which could
potentially hide legitimate problems.

Change-Id: I87a9838816b68f69a1fe1d02b06a41d218d49fce
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/98267
Pigweed-Auto-Submit: Karthik Bharadwaj <karthikmb@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
Reviewed-by: Wyatt Hepler <hepler@google.com>

pw_tokenizer/decode.cc

diff --git a/pw_tokenizer/decode.cc b/pw_tokenizer/decode.cc
index ea18c11..fce012f 100644
--- a/pw_tokenizer/decode.cc
+++ b/pw_tokenizer/decode.cc
@@ -184,11 +184,11 @@
 
   if (arguments.size() - 1 < size) {
     status.Update(ArgStatus::kDecodeError);
-    return DecodedArg(
-        status,
-        text_,
-        arguments.size(),
-        {reinterpret_cast<const char*>(&arguments[1]), arguments.size() - 1});
+    return DecodedArg(status,
+                      text_,
+                      arguments.size(),
+                      {reinterpret_cast<const char*>(&arguments[1]),
+                       static_cast<size_t>(arguments.size()) - 1});
   }
 
   std::string value(reinterpret_cast<const char*>(&arguments[1]), size);