commit 659a5c530a288a675295824a3a417f812bcfa691
author Prashanth Swaminathan <prashanthsw@google.com> Fri Feb 05 21:11:47 2021 -0800
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Mar 15 16:10:59 2021 +0000
tree 4eddba6b6a8bc06aae860aa9dab5bb1ba3682adf
parent 570ef76e88220171a9a71035362a0d51900c415f

pw_string: Add EXPECT calls for static analyzer

In addition to the existing static asserts, explicitly check the value
of test values using the EXPECT macros.

Change-Id: Ifad02d8058b1d7f60535cd8cf92c1d5bb5b2fa86
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/31972
Pigweed-Auto-Submit: Prashanth Swaminathan <prashanthsw@google.com>
Commit-Queue: Keir Mierle <keir@google.com>
Reviewed-by: Wyatt Hepler <hepler@google.com>
Reviewed-by: Keir Mierle <keir@google.com>

pw_string/string_builder_test.cc

diff --git a/pw_string/string_builder_test.cc b/pw_string/string_builder_test.cc
index c3bc3b0..0b092ad 100644
--- a/pw_string/string_builder_test.cc
+++ b/pw_string/string_builder_test.cc
@@ -523,12 +523,16 @@
 
   [[maybe_unused]] auto normal = MakeString("");
   static_assert(normal.max_size() == decltype(MakeString(1))::max_size());
+  EXPECT_EQ(normal.max_size(), decltype(MakeString(1))::max_size());
 
   [[maybe_unused]] auto resized =
       MakeString("This string is reeeeeeeeeaaaaallly long!!!!!");
   static_assert(resized.max_size() > decltype(MakeString(1))::max_size());
   static_assert(resized.max_size() ==
                 sizeof("This string is reeeeeeeeeaaaaallly long!!!!!") - 1);
+  EXPECT_GT(resized.max_size(), decltype(MakeString(1))::max_size());
+  EXPECT_EQ(resized.max_size(),
+            sizeof("This string is reeeeeeeeeaaaaallly long!!!!!") - 1);
 }
 
 TEST(MakeString, StringLiteral_UsesLongerFixedSize) {