commit 7a436e0697b6a03b47e4b286c047d98d3de6d921
author Ewout van Bekkum <ewout@google.com> Fri Oct 16 11:49:32 2020 -0700
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Oct 16 20:40:32 2020 +0000
tree 45def183d66b40fd12f9b597b73d2a08e9752d98
parent 4eb4218063ef5ff7a29d355042c1e6709e10a803

pw_build: Move "-Wcast-qual" to strict_warnings

Moves "-Wcast-qual" from extra_strict_warnings to strict_warnings.

Change-Id: Iab39c765c5222e6d6cbeac4933fd89874d06c695
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/21660
Reviewed-by: Ewout van Bekkum <ewout@google.com>
Reviewed-by: Wyatt Hepler <hepler@google.com>
Commit-Queue: Ewout van Bekkum <ewout@google.com>

pw_assert/public/pw_assert/internal/assert_impl.h

diff --git a/pw_assert/public/pw_assert/internal/assert_impl.h b/pw_assert/public/pw_assert/internal/assert_impl.h
index 32d20d4..35eab1e 100644
--- a/pw_assert/public/pw_assert/internal/assert_impl.h
+++ b/pw_assert/public/pw_assert/internal/assert_impl.h
@@ -84,12 +84,12 @@
 #define PW_DCHECK_UINT_NE(...) if (!(PW_ASSERT_ENABLE_DEBUG)) {} else PW_CHECK_UINT_NE(__VA_ARGS__)
 
 // Checks for pointer: LE, LT, GE, GT, EQ, NE.
-#define PW_CHECK_PTR_LE(arga, argb, ...) _PW_CHECK_BINARY_CMP_IMPL(arga, <=, argb, void*, "%p", __VA_ARGS__)
-#define PW_CHECK_PTR_LT(arga, argb, ...) _PW_CHECK_BINARY_CMP_IMPL(arga, < , argb, void*, "%p", __VA_ARGS__)
-#define PW_CHECK_PTR_GE(arga, argb, ...) _PW_CHECK_BINARY_CMP_IMPL(arga, >=, argb, void*, "%p", __VA_ARGS__)
-#define PW_CHECK_PTR_GT(arga, argb, ...) _PW_CHECK_BINARY_CMP_IMPL(arga, > , argb, void*, "%p", __VA_ARGS__)
-#define PW_CHECK_PTR_EQ(arga, argb, ...) _PW_CHECK_BINARY_CMP_IMPL(arga, ==, argb, void*, "%p", __VA_ARGS__)
-#define PW_CHECK_PTR_NE(arga, argb, ...) _PW_CHECK_BINARY_CMP_IMPL(arga, !=, argb, void*, "%p", __VA_ARGS__)
+#define PW_CHECK_PTR_LE(arga, argb, ...) _PW_CHECK_BINARY_CMP_IMPL(arga, <=, argb, const void*, "%p", __VA_ARGS__)
+#define PW_CHECK_PTR_LT(arga, argb, ...) _PW_CHECK_BINARY_CMP_IMPL(arga, < , argb, const void*, "%p", __VA_ARGS__)
+#define PW_CHECK_PTR_GE(arga, argb, ...) _PW_CHECK_BINARY_CMP_IMPL(arga, >=, argb, const void*, "%p", __VA_ARGS__)
+#define PW_CHECK_PTR_GT(arga, argb, ...) _PW_CHECK_BINARY_CMP_IMPL(arga, > , argb, const void*, "%p", __VA_ARGS__)
+#define PW_CHECK_PTR_EQ(arga, argb, ...) _PW_CHECK_BINARY_CMP_IMPL(arga, ==, argb, const void*, "%p", __VA_ARGS__)
+#define PW_CHECK_PTR_NE(arga, argb, ...) _PW_CHECK_BINARY_CMP_IMPL(arga, !=, argb, const void*, "%p", __VA_ARGS__)
 
 // Check for pointer: NOTNULL. Use "nullptr" in C++, "NULL" in C.
 #ifdef __cplusplus

pw_build/BUILD.gn

diff --git a/pw_build/BUILD.gn b/pw_build/BUILD.gn
index 61b57c5..26a7f50 100644
--- a/pw_build/BUILD.gn
+++ b/pw_build/BUILD.gn
@@ -71,6 +71,7 @@
     "-Wall",
     "-Wextra",
     "-Wimplicit-fallthrough",
+    "-Wcast-qual",
 
     # Make all warnings errors, except for the exemptions below.
     "-Werror",
@@ -84,12 +85,7 @@
 # enable, but are enabled for upstream Pigweed for maximum project
 # compatibility.
 config("extra_strict_warnings") {
-  cflags = [
-    "-Wshadow",
-
-    # Migrate the warning(s) below to strict_warnings once customers support it.
-    "-Wcast-qual",
-  ]
+  cflags = [ "-Wshadow" ]
 }
 
 config("cpp11") {