commit 7d59532b0e61db637e445ef91398974737ed4b18
author Rob Mohr <mohrr@google.com> Tue Sep 14 13:07:43 2021 -0700
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Sep 21 15:58:48 2021 +0000
tree 8a9cc1eef1dda947ff78d1aade7610bb86acb288
parent 28ad6f43fb04b85213fc8c46970f8202a4612950

pw_presubmit: Remove helpers from python_checks.py

Change-Id: Ie2d85696d27402509bcce20c71fc3692a7de98f9
Bug: 454
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/60922
Pigweed-Auto-Submit: Rob Mohr <mohrr@google.com>
Reviewed-by: Wyatt Hepler <hepler@google.com>
Reviewed-by: Keir Mierle <keir@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>

pw_presubmit/py/pw_presubmit/python_checks.py

diff --git a/pw_presubmit/py/pw_presubmit/python_checks.py b/pw_presubmit/py/pw_presubmit/python_checks.py
index 051d033..40260ab 100644
--- a/pw_presubmit/py/pw_presubmit/python_checks.py
+++ b/pw_presubmit/py/pw_presubmit/python_checks.py
@@ -19,7 +19,6 @@
 import logging
 import os
 import sys
-from typing import Callable, Tuple
 
 try:
     import pw_presubmit
@@ -47,30 +46,3 @@
 def gn_python_lint(ctx: pw_presubmit.PresubmitContext) -> None:
     build.gn_gen(ctx.root, ctx.output_dir)
     build.ninja(ctx.output_dir, 'python.lint')
-
-
-# TODO(mohrr) Remove gn_lint when downstream projects no longer reference it.
-gn_lint = gn_python_lint
-
-# TODO(pwbug/454) Remove after downstream projects switch to using functions
-# directly.
-_LINT_CHECKS = (gn_python_lint, )
-_ALL_CHECKS = (gn_python_check, )
-
-
-# TODO(pwbug/454) Remove after downstream projects switch to using functions
-# directly.
-def lint_checks(endswith: str = '.py',
-                **filter_paths_args) -> Tuple[Callable, ...]:
-    return tuple(
-        filter_paths(endswith=endswith, **filter_paths_args)(function)
-        for function in _LINT_CHECKS)
-
-
-# TODO(pwbug/454) Remove after downstream projects switch to using functions
-# directly.
-def all_checks(endswith: str = '.py',
-               **filter_paths_args) -> Tuple[Callable, ...]:
-    return tuple(
-        filter_paths(endswith=endswith, **filter_paths_args)(function)
-        for function in _ALL_CHECKS)