commit 99732b1f77c5b3a57943108947872efcfbe0d685
author Wyatt Hepler <hepler@google.com> Wed May 20 08:20:22 2020 -0700
committer Wyatt Hepler <hepler@google.com> Wed May 20 09:06:45 2020 -0700
tree a3c69e332b7dbd1fc2c7b1259a49259e121d98b0
parent c1b954273dd1b0a1ad0af7bf65186b9f79741b5c

pw_presubmit: Allow specifying setup.py roots

Allow external projects to specify setup.py roots in init_virtualenv.

Bug: 138

Change-Id: I6df944f6374ec4c6589782c040d00a20acab3b52

pw_presubmit/py/pw_presubmit/environment.py

diff --git a/pw_presubmit/py/pw_presubmit/environment.py b/pw_presubmit/py/pw_presubmit/environment.py
index 347895c..b798c3c 100644
--- a/pw_presubmit/py/pw_presubmit/environment.py
+++ b/pw_presubmit/py/pw_presubmit/environment.py
@@ -17,6 +17,7 @@
 import os
 from pathlib import Path
 import sys
+from typing import Iterable, Union
 
 from pw_presubmit import call
 
@@ -56,7 +57,11 @@
     _LOG.debug('PATH %s', os.environ['PATH'])
 
 
-def init_virtualenv(pigweed_root: Path, output_directory: Path) -> None:
+def init_virtualenv(
+        pigweed_root: Path,
+        output_directory: Path,
+        setup_py_roots: Iterable[Union[Path, str]] = (),
+) -> None:
     """Sets up a virtualenv, assumes recent Python 3 is already installed."""
     virtualenv_source = pigweed_root.joinpath('pw_env_setup', 'py',
                                               'pw_env_setup',
@@ -70,9 +75,8 @@
             'python3',
             virtualenv_source,
             f'--venv_path={output_directory}',
-            '--requirements={}'.format(
-                virtualenv_source.joinpath('requirements.txt')),
-            '--setup-py-roots={}'.format(pigweed_root),
+            f'--requirements={virtualenv_source / "requirements.txt"}',
+            *(f'--setup-py-root={p}' for p in [pigweed_root, *setup_py_roots]),
         )
 
     os.environ['PATH'] = os.pathsep.join((