commit b0098bf10aead951c6c51a51d1d7c52e4cdd71a6
author Wyatt Hepler <hepler@google.com> Tue Jan 17 19:44:05 2023 +0000
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jan 17 19:44:05 2023 +0000
tree d3fc7597ec4b582aed04df092aeb8bd03f627da2
parent 4e802589eebe5a6912a3da9146fab24b3a01e056

pw_rpc: Fix variable naming style in Java client test

Only static final variables should be capitalized.

Change-Id: I92182972d8c32f7e94e5e1cdc26ae8720154f470
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/126532
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
Reviewed-by: Anthony DiGirolamo <tonymd@google.com>
Pigweed-Auto-Submit: Wyatt Hepler <hepler@google.com>

pw_rpc/java/test/dev/pigweed/pw_rpc/StreamObserverMethodClientTest.java

diff --git a/pw_rpc/java/test/dev/pigweed/pw_rpc/StreamObserverMethodClientTest.java b/pw_rpc/java/test/dev/pigweed/pw_rpc/StreamObserverMethodClientTest.java
index 63cc5ea..36102f4 100644
--- a/pw_rpc/java/test/dev/pigweed/pw_rpc/StreamObserverMethodClientTest.java
+++ b/pw_rpc/java/test/dev/pigweed/pw_rpc/StreamObserverMethodClientTest.java
@@ -49,12 +49,12 @@
   // Wrap Channel.Output since channelOutput will be null when the channel is initialized.
   private final Channel channel = new Channel(1, bytes -> channelOutput.send(bytes));
 
-  private final PendingRpc UNARY_RPC = PendingRpc.create(channel, SERVICE.method("SomeUnary"));
-  private final PendingRpc SERVER_STREAMING_RPC =
+  private final PendingRpc unary_rpc = PendingRpc.create(channel, SERVICE.method("SomeUnary"));
+  private final PendingRpc server_streaming_rpc =
       PendingRpc.create(channel, SERVICE.method("SomeServerStreaming"));
-  private final PendingRpc CLIENT_STREAMING_RPC =
+  private final PendingRpc client_streaming_rpc =
       PendingRpc.create(channel, SERVICE.method("SomeClientStreaming"));
-  private final PendingRpc BIDIRECTIONAL_STREAMING_RPC =
+  private final PendingRpc bidirectional_streaming_rpc =
       PendingRpc.create(channel, SERVICE.method("SomeBidirectionalStreaming"));
 
   private final Client client = Client.create(ImmutableList.of(channel), ImmutableList.of(SERVICE));
@@ -65,13 +65,13 @@
 
   @Before
   public void createMethodClient() {
-    unaryMethodClient = new MethodClient(client, channel.id(), UNARY_RPC.method(), defaultObserver);
+    unaryMethodClient = new MethodClient(client, channel.id(), unary_rpc.method(), defaultObserver);
     serverStreamingMethodClient =
-        new MethodClient(client, channel.id(), SERVER_STREAMING_RPC.method(), defaultObserver);
+        new MethodClient(client, channel.id(), server_streaming_rpc.method(), defaultObserver);
     clientStreamingMethodClient =
-        new MethodClient(client, channel.id(), CLIENT_STREAMING_RPC.method(), defaultObserver);
+        new MethodClient(client, channel.id(), client_streaming_rpc.method(), defaultObserver);
     bidirectionalStreamingMethodClient = new MethodClient(
-        client, channel.id(), BIDIRECTIONAL_STREAMING_RPC.method(), defaultObserver);
+        client, channel.id(), bidirectional_streaming_rpc.method(), defaultObserver);
   }
 
   @Test
@@ -79,7 +79,7 @@
     unaryMethodClient.invokeUnary(SomeMessage.getDefaultInstance());
     AnotherMessage reply = AnotherMessage.newBuilder().setPayload("yo").build();
 
-    assertThat(client.processPacket(responsePacket(UNARY_RPC, reply))).isTrue();
+    assertThat(client.processPacket(responsePacket(unary_rpc, reply))).isTrue();
 
     verify(defaultObserver).onNext(reply);
   }
@@ -88,7 +88,7 @@
   public void invoke_usesProvidedObserver() throws Exception {
     unaryMethodClient.invokeUnary(SomeMessage.getDefaultInstance(), observer);
     AnotherMessage reply = AnotherMessage.newBuilder().setPayload("yo").build();
-    assertThat(client.processPacket(responsePacket(UNARY_RPC, reply))).isTrue();
+    assertThat(client.processPacket(responsePacket(unary_rpc, reply))).isTrue();
 
     verify(observer).onNext(reply);
   }
@@ -205,7 +205,7 @@
   @Test
   public void invalidChannel_throwsException() {
     MethodClient methodClient =
-        new MethodClient(client, 999, CLIENT_STREAMING_RPC.method(), defaultObserver);
+        new MethodClient(client, 999, client_streaming_rpc.method(), defaultObserver);
     assertThrows(InvalidRpcChannelException.class, methodClient::invokeClientStreaming);
   }