commit b6d5d7a537ca65afa0ecc67784f9b039a4866f93
author Prashanth Swaminathan <prashanthsw@google.com> Wed Feb 03 12:53:52 2021 -0800
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Sat Feb 06 02:53:24 2021 +0000
tree 962c19a1b59afc5b30630a32968dd3e54f559fd0
parent c9968630bcfe0d3ad7fc3c4629c2ab6305d52dc9

pw_kvs: Add attributes on unused variables for debug

Appends [[maybe_unused]] to some variables that are only used in DBG
statements to satisfy the static analyzer.

Change-Id: If692c6c6d102a0540ee12fc1811fe0136d715ada
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/31660
Reviewed-by: Wyatt Hepler <hepler@google.com>
Reviewed-by: Keir Mierle <keir@google.com>
Commit-Queue: Prashanth Swaminathan <prashanthsw@google.com>

pw_kvs/key_value_store.cc

diff --git a/pw_kvs/key_value_store.cc b/pw_kvs/key_value_store.cc
index 9823ae9..d40bb8b 100644
--- a/pw_kvs/key_value_store.cc
+++ b/pw_kvs/key_value_store.cc
@@ -946,7 +946,7 @@
 Status KeyValueStore::GarbageCollect(
     std::span<const Address> reserved_addresses) {
   DBG("Garbage Collect a single sector");
-  for (Address address : reserved_addresses) {
+  for ([[maybe_unused]] Address address : reserved_addresses) {
     DBG("   Avoid address %u", unsigned(address));
   }
 
@@ -1288,7 +1288,7 @@
   for (size_t sector_id = 0; sector_id < sectors_.size(); ++sector_id) {
     // Read sector data. Yes, this will blow the stack on embedded.
     std::array<byte, 500> raw_sector_data;  // TODO!!!
-    StatusWithSize sws =
+    [[maybe_unused]] StatusWithSize sws =
         partition_.Read(sector_id * sector_size_bytes, raw_sector_data);
     DBG("Read: %u bytes", unsigned(sws.size()));