commit b931c8367ce21ddb1d2255cb38f7869ccab44f1a
author Michael Spang <spang@google.com> Thu Jan 21 02:36:37 2021 -0500
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Jan 21 16:51:12 2021 +0000
tree 404700d8c8d0e5ec1b7980e669ba4f366463852d
parent 7abd8cc3879b6e54eb842bf024c36a292330f774

pw_toolchain: Fix long command lines on Windows

Link commands can easily exceed command line length limits on Windows:

  ninja: fatal: CreateProcess: The parameter is incorrect.
   (is the command line too long?)

Use the response file to avoid these limits.

Bug: 289
Change-Id: Id3e8f81462fa28da06f95ee50f8e61ed67b9ecc2
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/30200
Reviewed-by: Alexei Frolov <frolv@google.com>
Commit-Queue: Michael Spang <spang@google.com>

pw_toolchain/generate_toolchain.gni

diff --git a/pw_toolchain/generate_toolchain.gni b/pw_toolchain/generate_toolchain.gni
index 988d5a8..3d539c0 100644
--- a/pw_toolchain/generate_toolchain.gni
+++ b/pw_toolchain/generate_toolchain.gni
@@ -200,11 +200,13 @@
 
       assert(defined(invoker.ar), "toolchain is missing 'ar'")
       tool("alink") {
+        rspfile = "{{output}}.rsp"
+        rspfile_content = "{{inputs}}"
         if (host_os == "win") {
-          command = "${invoker.ar} rcs {{output}} {{inputs}}"
+          command = "${invoker.ar} rcs {{output}} @\"$rspfile\""
         } else {
           command =
-              "rm -f {{output}} && ${invoker.ar} rcs {{output}} {{inputs}}"
+              "rm -f {{output}} && ${invoker.ar} rcs {{output}} @\"$rspfile\""
         }
         description = "ar {{target_output_name}}{{output_extension}}"
         outputs =
@@ -218,11 +220,15 @@
 
       _link_outfile =
           "{{output_dir}}/{{target_output_name}}{{output_extension}}"
+      _link_rspfile = _link_outfile + ".rsp"
+
       _link_mapfile = "{{output_dir}}/{{target_output_name}}.map"
-      _link_flags = [
-        invoker.cxx,
-        "{{ldflags}}",
-      ]
+      _link_command = string_join(" ",
+                                  [
+                                    invoker.cxx,
+                                    "@\"$_link_rspfile\"",
+                                  ])
+      _link_flags = [ "{{ldflags}}" ]
 
       if (toolchain_os == "mac" || toolchain_os == "ios") {
         _link_flags += [
@@ -272,10 +278,12 @@
       }
       _link_flags += [ "-o $_link_outfile" ]
 
-      _link_command = string_join(" ", _link_flags)
+      _link_rspfile_content = string_join(" ", _link_flags)
 
       tool("link") {
         command = _link_command
+        rspfile = _link_rspfile
+        rspfile_content = _link_rspfile_content
         description = "ld $_link_outfile"
         outputs = [ _link_outfile ]
         default_output_dir = "{{target_out_dir}}/bin"
@@ -291,6 +299,8 @@
 
       tool("solink") {
         command = _link_command + " -shared"
+        rspfile = _link_rspfile
+        rspfile_content = _link_rspfile_content
         description = "ld -shared $_link_outfile"
         outputs = [ _link_outfile ]
         default_output_dir = "{{target_out_dir}}/lib"