commit db0c6d9ed55ab0e377fc8b5abddb1a6770effe36
author Rob Mohr <mohrr@google.com> Wed Feb 24 09:01:10 2021 -0800
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Feb 24 23:48:54 2021 +0000
tree 9a1c8461855629429c11c9796682a19abfe22839
parent f6467e0dc825f4eea22818d3283af39117f3625c

pw_presubmit: Remove init steps

Remove unused init_cipd and init_virtualenv steps and create lintformat
program.

Change-Id: I4b8d67c2545a6e6d9b7a2fb19b68fc3ee3b19338
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/33760
Pigweed-Auto-Submit: Rob Mohr <mohrr@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
Reviewed-by: Ewout van Bekkum <ewout@google.com>

pw_presubmit/py/pw_presubmit/pigweed_presubmit.py

diff --git a/pw_presubmit/py/pw_presubmit/pigweed_presubmit.py b/pw_presubmit/py/pw_presubmit/pigweed_presubmit.py
index f77d262..cade0aa 100755
--- a/pw_presubmit/py/pw_presubmit/pigweed_presubmit.py
+++ b/pw_presubmit/py/pw_presubmit/pigweed_presubmit.py
@@ -34,7 +34,7 @@
 
 import pw_package.pigweed_packages
 
-from pw_presubmit import build, cli, environment, format_code, git_repo
+from pw_presubmit import build, cli, format_code, git_repo
 from pw_presubmit import call, filter_paths, plural, PresubmitContext
 from pw_presubmit import PresubmitFailure, Programs
 from pw_presubmit.install_hook import install_hook
@@ -43,25 +43,6 @@
 
 pw_package.pigweed_packages.initialize()
 
-
-#
-# Initialization
-#
-def init_cipd(ctx: PresubmitContext):
-    environment.init_cipd(ctx.root, ctx.output_dir)
-
-
-def init_virtualenv(ctx: PresubmitContext):
-    environment.init_virtualenv(
-        ctx.root,
-        ctx.output_dir,
-        gn_targets=(
-            f'{ctx.root}#:python.install',
-            f'{ctx.root}#:target_support_packages.install',
-        ),
-    )
-
-
 # Trigger builds if files with these extensions change.
 _BUILD_EXTENSIONS = ('.py', '.rst', '.gn', '.gni',
                      *format_code.C_FORMAT.extensions)
@@ -515,12 +496,16 @@
     gn_nanopb_build,
 )
 
-QUICK = (
+LINTFORMAT = (
     commit_message_format,
-    source_is_in_build_files,
     copyright_notice,
     format_code.presubmit_checks(),
     pw_presubmit.pragma_once,
+    source_is_in_build_files,
+)
+
+QUICK = (
+    LINTFORMAT,
     gn_quick_build_check,
     # TODO(pwbug/141): Re-enable CMake and Bazel for Mac after we have fixed the
     # the clang issues. The problem is that all clang++ invocations need the
@@ -529,12 +514,7 @@
 )
 
 FULL = (
-    commit_message_format,
-    init_cipd,
-    init_virtualenv,
-    copyright_notice,
-    format_code.presubmit_checks(),
-    pw_presubmit.pragma_once,
+    LINTFORMAT,
     gn_clang_build,
     gn_arm_build,
     gn_docs_build,
@@ -553,7 +533,12 @@
     gn_teensy_build if sys.platform in ['linux', 'darwin'] else (),
 )
 
-PROGRAMS = Programs(broken=BROKEN, quick=QUICK, full=FULL)
+PROGRAMS = Programs(
+    broken=BROKEN,
+    quick=QUICK,
+    full=FULL,
+    lintformat=LINTFORMAT,
+)
 
 
 def parse_args() -> argparse.Namespace: