commit f47febb0da2dd27118d3c8134b957cb79fc5f26f
author Michael Spang <spang@google.com> Sun Mar 28 20:21:43 2021 -0400
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Apr 01 21:21:10 2021 +0000
tree b5c8d36c534c34b9fc1688e875c48e7d74b69b45
parent 5ea3340c283bc59773ea1ef7f1810faa2f2c9655

pw_toolchain: Add missing {{arflags} to tool("alink")

GN configs support flags for ar. Typically it is used to enable thin
archives. Allow this in pigweed.

No-Docs-Update-Reason: We're not documenting GN here.

Change-Id: I663750e49adaf67cb4274776d93c946b4d4919b0
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/39440
Commit-Queue: Michael Spang <spang@google.com>
Reviewed-by: Armando Montanez <amontanez@google.com>

pw_toolchain/generate_toolchain.gni

diff --git a/pw_toolchain/generate_toolchain.gni b/pw_toolchain/generate_toolchain.gni
index ccc1c36..5be80eb5 100644
--- a/pw_toolchain/generate_toolchain.gni
+++ b/pw_toolchain/generate_toolchain.gni
@@ -223,10 +223,9 @@
           rspfile = "{{output}}.rsp"
           rspfile_content = "{{inputs}}"
           rm_command = "del /F /Q \"{{output}}\" 2> NUL"
-          command = "cmd /c \"($rm_command) & ${invoker.ar} rcs {{output}} @$rspfile\""
+          command = "cmd /c \"($rm_command) & ${invoker.ar} {{arflags}} rcs {{output}} @$rspfile\""
         } else {
-          command =
-              "rm -f {{output}} && ${invoker.ar} rcs {{output}} {{inputs}}"
+          command = "rm -f {{output}} && ${invoker.ar} {{arflags}} rcs {{output}} {{inputs}}"
         }
 
         description = "ar {{target_output_name}}{{output_extension}}"