commit f48241063b6104a0273aa475df19984cc60c28e6
author Michael Spang <spang@google.com> Tue Jun 08 18:57:48 2021 -0400
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Jun 09 01:11:35 2021 +0000
tree 6a69fcd2447200c1b88ec2042db74815803e9114
parent 89ff5f98f38b1ff7a1ff0633c590479e9b592a14

env_setup: Don't write the spinner to files

Avoid writing backspace character to logs files as this just makes the
log harder to read.

No-Docs-Update-Reason: no API change
Change-Id: I4040e2198a610fe13d655ab37b95c73c92f50c02
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/48400
Reviewed-by: Rob Mohr <mohrr@google.com>
Commit-Queue: Michael Spang <spang@google.com>

pw_env_setup/py/pw_env_setup/spinner.py

diff --git a/pw_env_setup/py/pw_env_setup/spinner.py b/pw_env_setup/py/pw_env_setup/spinner.py
index 63d577ea..ac70093 100644
--- a/pw_env_setup/py/pw_env_setup/spinner.py
+++ b/pw_env_setup/py/pw_env_setup/spinner.py
@@ -22,6 +22,11 @@
 PW_ENVSETUP_DISABLE_SPINNER = os.environ.get('PW_ENVSETUP_DISABLE_SPINNER')
 
 
+def _disabled():
+    return PW_ENVSETUP_DISABLE_SPINNER or (PW_ENVSETUP_DISABLE_SPINNER is None
+                                           and not sys.stdout.isatty())
+
+
 class Spinner(object):  # pylint: disable=useless-object-inheritance
     """Spinner!"""
     def __init__(self):
@@ -42,7 +47,7 @@
             i = (i + 1) % len(chars)
 
     def start(self):
-        if PW_ENVSETUP_DISABLE_SPINNER:
+        if _disabled():
             return
 
         self._done = False
@@ -50,7 +55,7 @@
         self._thread.start()
 
     def stop(self):
-        if PW_ENVSETUP_DISABLE_SPINNER:
+        if _disabled():
             return
 
         assert self._thread