| commit | d086467012e1970f44f27b67b4296a2a6fb097d5 | [log] [tgz] |
|---|---|---|
| author | Karsten Pfeiffer-Raddatz <raddatz.karsten@gmail.com> | Mon Apr 13 13:48:04 2020 +0200 |
| committer | Karsten Pfeiffer-Raddatz <raddatz.karsten@gmail.com> | Tue Apr 14 06:49:31 2020 +0000 |
| tree | 05507d1ec39195eba657eb1b2b851261981564b9 | |
| parent | 2735bfc5ff6599fd3ca9a361484259908d03804d [diff] |
forall.py: Close file after removing the stream In order to remove the stream fileno() will be called on the filedescriptor. If the file is already closed fileno() will raise an error and forall will fail. Bug: https://crbug.com/gerrit/12563 Change-Id: Ib7b895fe881c844e3eb3672b011fdcdbdae63024 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/262838 Reviewed-by: David Pursehouse <dpursehouse@collab.net> Tested-by: Karsten Pfeiffer-Raddatz <raddatz.karsten@gmail.com>
diff --git a/subcmds/forall.py b/subcmds/forall.py index 74d1ede..a13793d 100644 --- a/subcmds/forall.py +++ b/subcmds/forall.py
@@ -370,8 +370,8 @@ for s in in_ready: buf = s.read().decode() if not buf: - s.close() s_in.remove(s) + s.close() continue if not opt.verbose: