commit e20da3eeedf03dcffbb882ca10b159719f8e334d
author Mike Frysinger <vapier@google.com> Sat Mar 07 01:53:53 2020 -0500
committer David Pursehouse <dpursehouse@collab.net> Sat Mar 07 13:10:14 2020 +0000
tree 31e3eca7a95fb1dbf9baaad5aaa9bc3a7c17d20b
parent 910dfe84978b6ed3400e367c6a9f3cb3f17a2384

sync: fix os.environ logic errors

This is a dict to index, not a function to call.

Change-Id: I0117eeaaa8b2ef4762ab6f0d22f9ffdaee961f52
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/258132
Tested-by: Mike Frysinger <vapier@google.com>
Reviewed-by: David Pursehouse <dpursehouse@collab.net>

subcmds/sync.py

diff --git a/subcmds/sync.py b/subcmds/sync.py
index e2bc1d1..ae29f08 100644
--- a/subcmds/sync.py
+++ b/subcmds/sync.py
@@ -729,12 +729,12 @@
           branch = branch[len(R_HEADS):]
 
         if 'SYNC_TARGET' in os.environ:
-          target = os.environ('SYNC_TARGET')
+          target = os.environ['SYNC_TARGET']
           [success, manifest_str] = server.GetApprovedManifest(branch, target)
         elif ('TARGET_PRODUCT' in os.environ and
               'TARGET_BUILD_VARIANT' in os.environ):
-          target = '%s-%s' % (os.environ('TARGET_PRODUCT'),
-                              os.environ('TARGET_BUILD_VARIANT'))
+          target = '%s-%s' % (os.environ['TARGET_PRODUCT'],
+                              os.environ['TARGET_BUILD_VARIANT'])
           [success, manifest_str] = server.GetApprovedManifest(branch, target)
         else:
           [success, manifest_str] = server.GetApprovedManifest(branch)