Merge #596 by ted-xie: Exempt external repository targets from aar_import dependency checks Commit cbdf292 (CL 1014964495) dropped the `aar_import` dependency checker allowlist in favor of the `incomplete-deps-this-may-cause-runtime-errors` tag. External Maven dependencies generated by `rules_jvm_external` do not carry this internal tag, causing `ImportDepsChecker` to run unconditionally on third-party AARs and fail on optional compile-time dependencies. Restrict default `aar_import` dependency checking to main repository targets, keeping external dependencies exempt. Closes #596 COPYBARA_INTEGRATE_REVIEW=https://github.com/bazelbuild/rules_android/pull/596 from ted-xie:fix-aar-import-deps d4d846fa326e92c605c78cf17f53efcf051db2df PiperOrigin-RevId: 1021160787 Change-Id: If2231416053f481b784e90ab54a71c260c10c758
diff --git a/rules/aar_import/impl.bzl b/rules/aar_import/impl.bzl index b994155..f68f770 100644 --- a/rules/aar_import/impl.bzl +++ b/rules/aar_import/impl.bzl
@@ -463,6 +463,10 @@ transitive_proguard_specs.append(p.specs) return ProguardSpecInfo(depset([out_proguard], transitive = transitive_proguard_specs)) +def _is_external_target(label): + fqn = str(label) + return fqn.startswith("@") and not fqn.startswith("@//") and not fqn.startswith("@@//") + def impl(ctx): """The rule implementation. @@ -515,7 +519,10 @@ r_java = resources_ctx.r_java, exports = _utils.collect_providers(JavaInfo, ctx.attr.exports), enable_desugar_java8 = read_possibly_native_flag(ctx, "desugar_for_android"), - enable_imports_deps_check = INCOMPLETE_DEPS_TAG not in ctx.attr.tags, + enable_imports_deps_check = ( + not _is_external_target(ctx.label) and + INCOMPLETE_DEPS_TAG not in ctx.attr.tags + ), aar_embedded_jars_extractor_tool = _get_android_toolchain(ctx).aar_embedded_jars_extractor.files_to_run, bootclasspath =