Convention fix (#126)
* Refactor `base_name` to `name` according to the Bazel conventions https://docs.bazel.build/versions/master/skylark/macros.html#conventions.
* Minor typo fix.
diff --git a/docs/BUILD b/docs/BUILD
index d414368..7c737a9 100644
--- a/docs/BUILD
+++ b/docs/BUILD
@@ -15,7 +15,7 @@
# Documentation files for the Bazel fuzzing rules.
# To regenerate, run the 'update_docs.sh' script in the root directory.
-# Since the 'bzl_library' rule is currenly used only for documentation
+# Since the 'bzl_library' rule is currently used only for documentation
# generation, we define all libraries here, to avoid introducing a Skylib
# dependency on our users.
load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
diff --git a/fuzzing/private/fuzz_test.bzl b/fuzzing/private/fuzz_test.bzl
index fd8e77f..9bbb5c5 100644
--- a/fuzzing/private/fuzz_test.bzl
+++ b/fuzzing/private/fuzz_test.bzl
@@ -21,7 +21,7 @@
load("//fuzzing/private/oss_fuzz:package.bzl", "oss_fuzz_package")
def fuzzing_decoration(
- base_name,
+ name,
raw_binary,
engine,
corpus = None,
@@ -36,7 +36,7 @@
documentation for the set of targets generated.
Args:
- base_name: The name prefix of the generated targets. It is normally the
+ name: The name prefix of the generated targets. It is normally the
fuzz test name in the BUILD file.
raw_binary: The label of the cc_binary or cc_test of fuzz test
executable.
@@ -67,10 +67,10 @@
# targets and their runfiles would be transferred from the remote cache to
# the local machine, ballooning the size of the output.
- instrum_binary_name = base_name + "_bin"
- launcher_name = base_name + "_run"
- corpus_name = base_name + "_corpus"
- dict_name = base_name + "_dict"
+ instrum_binary_name = name + "_bin"
+ launcher_name = name + "_run"
+ corpus_name = name + "_corpus"
+ dict_name = name + "_dict"
if instrument_binary:
fuzzing_binary(
@@ -103,7 +103,7 @@
fuzzing_dictionary(
name = dict_name,
dicts = dicts,
- output = base_name + ".dict",
+ output = name + ".dict",
testonly = True,
)
@@ -116,14 +116,14 @@
if define_regression_test:
fuzzing_regression_test(
- name = base_name,
+ name = name,
binary = instrum_binary_name,
tags = test_tags,
)
oss_fuzz_package(
- name = base_name + "_oss_fuzz",
- base_name = base_name,
+ name = name + "_oss_fuzz",
+ base_name = name,
binary = instrum_binary_name,
testonly = True,
tags = ["manual"],
@@ -176,7 +176,7 @@
)
fuzzing_decoration(
- base_name = name,
+ name = name,
raw_binary = raw_binary_name,
engine = engine,
corpus = corpus,
