refactor: expose base rule construction via builders to allow customization for testing (#2600)

The py_reconfig rules work by wrapping: The outer reconfig rule applies
a transition, depends
on an inner py base rule, then jumps through various hoops to ensure it
looks and acts
like the target it's wrapping.

This is error prone, incomplete, and annoying code to maintain. Phil
recently discovered it wasn't properly propagating the output group, so
he had to add that. I wasted time trying to fix a bug I _thought_ was in
it, but actually was working correctly. The logic within it is a bit
hacky as it tries to emulate some of the platform-specific stuff for
windows. Every time
py_reconfig gains something to transition on, there's numerous places to
define, propagate,
and extract the pieces necessary to do it.

To fix this, make the py_reconfig rules not wrap an inner base py rule.
Instead, they use the same underlying rule args that the base rules do.
This lets them act directly as the rule they're designed to test.

Customization is done by capturing all the rule args in builder objects.
The py_reconfig code constructs the same builder the base rules do, then
modifies it as necessary (adding attributes, wrapping the base
transition function). As a bonus, this sets some ground work to allow
more easily defining derivative rules without having to copy/paste
arbitrary parts of how the base rules are defined.

Work towards https://github.com/bazelbuild/rules_python/issues/1647
8 files changed
tree: 585973c68555a0937083767b06beff3f8e54be77
  1. .bazelci/
  2. .bcr/
  3. .ci/
  4. .github/
  5. docs/
  6. examples/
  7. gazelle/
  8. private/
  9. python/
  10. sphinxdocs/
  11. tests/
  12. third_party/
  13. tools/
  14. .bazelignore
  15. .bazelrc
  16. .bazelversion
  17. .git-blame-ignore-revs
  18. .gitattributes
  19. .gitignore
  20. .pre-commit-config.yaml
  21. .readthedocs.yml
  22. addlicense.sh
  23. AUTHORS
  24. BUILD.bazel
  25. BZLMOD_SUPPORT.md
  26. CHANGELOG.md
  27. CONTRIBUTING.md
  28. CONTRIBUTORS
  29. DEVELOPING.md
  30. internal_dev_deps.bzl
  31. internal_dev_setup.bzl
  32. LICENSE
  33. MODULE.bazel
  34. README.md
  35. version.bzl
  36. WORKSPACE
  37. WORKSPACE.bzlmod
README.md

Python Rules for Bazel

Build status

Overview

This repository is the home of the core Python rules -- py_library, py_binary, py_test, py_proto_library, and related symbols that provide the basis for Python support in Bazel. It also contains package installation rules for integrating with PyPI and other indices.

Documentation for rules_python is at https://rules-python.readthedocs.io and in the Bazel Build Encyclopedia.

Examples live in the examples directory.

The core rules are stable. Their implementation is subject to Bazel's backward compatibility policy. This repository aims to follow semantic versioning.

The Bazel community maintains this repository. Neither Google nor the Bazel team provides support for the code. However, this repository is part of the test suite used to vet new Bazel releases. See How to contribute page for information on our development workflow.

Documentation

For detailed documentation, see https://rules-python.readthedocs.io

Bzlmod support

  • Status: Beta
  • Full Feature Parity: No

See Bzlmod support for more details.