fix(sphinxdocs): stop hardcoding --show-traceback in sphinx_docs (#4470) Hardcoding `--show-traceback` in `sphinx_docs` produces noisy Python stack traces on failed documentation builds and prevents opting out of them. Remove `--show-traceback` from the default `sphinx_docs` build and `.run` arguments so Sphinx uses its default error output unless callers pass `extra_opts = ["--show-traceback"]`. Fixes #4469
diff --git a/sphinxdocs/sphinxdocs/private/sphinx.bzl b/sphinxdocs/sphinxdocs/private/sphinx.bzl index 24c5e9f..4af6350 100644 --- a/sphinxdocs/sphinxdocs/private/sphinx.bzl +++ b/sphinxdocs/sphinxdocs/private/sphinx.bzl
@@ -283,8 +283,6 @@ args.add(source_path) args.add(output_dir.path) - args.add("--show-traceback") # Full tracebacks on error - run_args.append("--show-traceback") args.add(format, format = "--builder=%s") run_args.append("--builder={}".format(format))