commit 972ea316b6932604cceb847718831c9edc24c050
author UebelAndre <github@uebelandre.com> Wed Oct 23 11:18:32 2024 -0700
committer GitHub <noreply@github.com> Wed Oct 23 18:18:32 2024 +0000
tree 67fe8357c1a4f8864f2c4d969b91a20aeb0ee630
parent 376714c12dea77cf3f1011b71b64ffacd402d268

Flipped `incompatible_runfiles_cargo_manifest_dir` (#2948)

.bazelci/presubmit.yml

diff --git a/.bazelci/presubmit.yml b/.bazelci/presubmit.yml
index 2c9613d..8fb800f 100644
--- a/.bazelci/presubmit.yml
+++ b/.bazelci/presubmit.yml
@@ -98,10 +98,8 @@
     platform: windows
     build_flags:
       - "--noenable_runfiles"
-      - "--//cargo/settings:incompatible_runfiles_cargo_manifest_dir=true"
     test_flags:
       - "--noenable_runfiles"
-      - "--//cargo/settings:incompatible_runfiles_cargo_manifest_dir=true"
     build_targets: *default_windows_no_runfiles_targets
     test_targets: *default_windows_no_runfiles_targets
   ubuntu2004_split_coverage_postprocessing:
@@ -204,12 +202,10 @@
       - "--noenable_runfiles"
       - "--config=rustfmt"
       - "--config=clippy"
-      - "--//cargo/settings:incompatible_runfiles_cargo_manifest_dir=true"
     test_flags:
       - "--noenable_runfiles"
       - "--config=rustfmt"
       - "--config=clippy"
-      - "--//cargo/settings:incompatible_runfiles_cargo_manifest_dir=true"
     build_targets: *default_windows_no_runfiles_targets
     test_targets: *default_windows_no_runfiles_targets
   windows_rolling_with_aspects:

cargo/settings/BUILD.bazel

diff --git a/cargo/settings/BUILD.bazel b/cargo/settings/BUILD.bazel
index b29ef2e..326121e 100644
--- a/cargo/settings/BUILD.bazel
+++ b/cargo/settings/BUILD.bazel
@@ -15,7 +15,7 @@
 # https://github.com/bazelbuild/bazel/issues/15486
 bool_flag(
     name = "incompatible_runfiles_cargo_manifest_dir",
-    build_setting_default = False,
+    build_setting_default = True,
 )
 
 # A flag which determines what files are retained in `CARGO_MANIFEST_DIR` directories