drivers/display/display_ili9xxx.c - third_party/github/zephyrproject-rtos/zephyr - Git at Google

 /*
  * Copyright (c) 2017 Jan Van Winkel <jan.van_winkel@dxplore.eu>
  * Copyright (c) 2019 Nordic Semiconductor ASA
  * Copyright (c) 2020 Teslabs Engineering S.L.
  * Copyright (c) 2021 Krivorot Oleg <krivorot.oleg@gmail.com>
  * SPDX-License-Identifier: Apache-2.0
  */

 #include "display_ili9xxx.h"

 #include <zephyr/dt-bindings/display/ili9xxx.h>
 #include <zephyr/drivers/display.h>
 #include <zephyr/sys/byteorder.h>

 #include <zephyr/logging/log.h>
 LOG_MODULE_REGISTER(display_ili9xxx, CONFIG_DISPLAY_LOG_LEVEL);

 struct ili9xxx_data {
 	uint8_t bytes_per_pixel;
 	enum display_pixel_format pixel_format;
 	enum display_orientation orientation;
 };

 int ili9xxx_transmit(const struct device *dev, uint8_t cmd, const void *tx_data,
 		     size_t tx_len)
 {
 	const struct ili9xxx_config *config = dev->config;

 	int r;
 	struct spi_buf tx_buf;
 	struct spi_buf_set tx_bufs = { .buffers = &tx_buf, .count = 1U };

 	/* send command */
 	tx_buf.buf = &cmd;
 	tx_buf.len = 1U;

 	gpio_pin_set_dt(&config->cmd_data, ILI9XXX_CMD);
 	r = spi_write_dt(&config->spi, &tx_bufs);
 	if (r < 0) {
 		return r;
 	}

 	/* send data (if any) */
 	if (tx_data != NULL) {
 		tx_buf.buf = (void *)tx_data;
 		tx_buf.len = tx_len;

 		gpio_pin_set_dt(&config->cmd_data, ILI9XXX_DATA);
 		r = spi_write_dt(&config->spi, &tx_bufs);
 		if (r < 0) {
 			return r;
 		}
 	}

 	return 0;
 }

 static int ili9xxx_exit_sleep(const struct device *dev)
 {
 	int r;

 	r = ili9xxx_transmit(dev, ILI9XXX_SLPOUT, NULL, 0);
 	if (r < 0) {
 		return r;
 	}

 	k_sleep(K_MSEC(ILI9XXX_SLEEP_OUT_TIME));

 	return 0;
 }

 static void ili9xxx_hw_reset(const struct device *dev)
 {
 	const struct ili9xxx_config *config = dev->config;

 	if (config->reset.port == NULL) {
 		return;
 	}

 	gpio_pin_set_dt(&config->reset, 1);
 	k_sleep(K_MSEC(ILI9XXX_RESET_PULSE_TIME));
 	gpio_pin_set_dt(&config->reset, 0);

 	k_sleep(K_MSEC(ILI9XXX_RESET_WAIT_TIME));
 }

 static int ili9xxx_set_mem_area(const struct device *dev, const uint16_t x,
 				const uint16_t y, const uint16_t w,
 				const uint16_t h)
 {
 	int r;
 	uint16_t spi_data[2];

 	spi_data[0] = sys_cpu_to_be16(x);
 	spi_data[1] = sys_cpu_to_be16(x + w - 1U);
 	r = ili9xxx_transmit(dev, ILI9XXX_CASET, &spi_data[0], 4U);
 	if (r < 0) {
 		return r;
 	}

 	spi_data[0] = sys_cpu_to_be16(y);
 	spi_data[1] = sys_cpu_to_be16(y + h - 1U);
 	r = ili9xxx_transmit(dev, ILI9XXX_PASET, &spi_data[0], 4U);
 	if (r < 0) {
 		return r;
 	}

 	return 0;
 }

 static int ili9xxx_write(const struct device *dev, const uint16_t x,
 			 const uint16_t y,
 			 const struct display_buffer_descriptor *desc,
 			 const void *buf)
 {
 	const struct ili9xxx_config *config = dev->config;
 	struct ili9xxx_data *data = dev->data;

 	int r;
 	const uint8_t *write_data_start = (const uint8_t *)buf;
 	struct spi_buf tx_buf;
 	struct spi_buf_set tx_bufs;
 	uint16_t write_cnt;
 	uint16_t nbr_of_writes;
 	uint16_t write_h;

 	__ASSERT(desc->width <= desc->pitch, "Pitch is smaller than width");
 	__ASSERT((desc->pitch * data->bytes_per_pixel * desc->height) <=
 			 desc->buf_size,
 		 "Input buffer to small");

 	LOG_DBG("Writing %dx%d (w,h) @ %dx%d (x,y)", desc->width, desc->height,
 		x, y);
 	r = ili9xxx_set_mem_area(dev, x, y, desc->width, desc->height);
 	if (r < 0) {
 		return r;
 	}

 	if (desc->pitch > desc->width) {
 		write_h = 1U;
 		nbr_of_writes = desc->height;
 	} else {
 		write_h = desc->height;
 		nbr_of_writes = 1U;
 	}

 	r = ili9xxx_transmit(dev, ILI9XXX_RAMWR, write_data_start,
 			     desc->width * data->bytes_per_pixel * write_h);
 	if (r < 0) {
 		return r;
 	}

 	tx_bufs.buffers = &tx_buf;
 	tx_bufs.count = 1;

 	write_data_start += desc->pitch * data->bytes_per_pixel;
 	for (write_cnt = 1U; write_cnt < nbr_of_writes; ++write_cnt) {
 		tx_buf.buf = (void *)write_data_start;
 		tx_buf.len = desc->width * data->bytes_per_pixel * write_h;

 		r = spi_write_dt(&config->spi, &tx_bufs);
 		if (r < 0) {
 			return r;
 		}

 		write_data_start += desc->pitch * data->bytes_per_pixel;
 	}

 	return 0;
 }

 static int ili9xxx_read(const struct device *dev, const uint16_t x,
 			const uint16_t y,
 			const struct display_buffer_descriptor *desc, void *buf)
 {
 	LOG_ERR("Reading not supported");
 	return -ENOTSUP;
 }

 static void *ili9xxx_get_framebuffer(const struct device *dev)
 {
 	LOG_ERR("Direct framebuffer access not supported");
 	return NULL;
 }

 static int ili9xxx_display_blanking_off(const struct device *dev)
 {
 	LOG_DBG("Turning display blanking off");
 	return ili9xxx_transmit(dev, ILI9XXX_DISPON, NULL, 0);
 }

 static int ili9xxx_display_blanking_on(const struct device *dev)
 {
 	LOG_DBG("Turning display blanking on");
 	return ili9xxx_transmit(dev, ILI9XXX_DISPOFF, NULL, 0);
 }

 static int ili9xxx_set_brightness(const struct device *dev,
 				  const uint8_t brightness)
 {
 	LOG_ERR("Set brightness not implemented");
 	return -ENOTSUP;
 }

 static int ili9xxx_set_contrast(const struct device *dev,
 				const uint8_t contrast)
 {
 	LOG_ERR("Set contrast not supported");
 	return -ENOTSUP;
 }

 static int
 ili9xxx_set_pixel_format(const struct device *dev,
 			 const enum display_pixel_format pixel_format)
 {
 	struct ili9xxx_data *data = dev->data;

 	int r;
 	uint8_t tx_data;
 	uint8_t bytes_per_pixel;

 	if (pixel_format == PIXEL_FORMAT_RGB_565) {
 		bytes_per_pixel = 2U;
 		tx_data = ILI9XXX_PIXSET_MCU_16_BIT | ILI9XXX_PIXSET_RGB_16_BIT;
 	} else if (pixel_format == PIXEL_FORMAT_RGB_888) {
 		bytes_per_pixel = 3U;
 		tx_data = ILI9XXX_PIXSET_MCU_18_BIT | ILI9XXX_PIXSET_RGB_18_BIT;
 	} else {
 		LOG_ERR("Unsupported pixel format");
 		return -ENOTSUP;
 	}

 	r = ili9xxx_transmit(dev, ILI9XXX_PIXSET, &tx_data, 1U);
 	if (r < 0) {
 		return r;
 	}

 	data->pixel_format = pixel_format;
 	data->bytes_per_pixel = bytes_per_pixel;

 	return 0;
 }

 static int ili9xxx_set_orientation(const struct device *dev,
 				   const enum display_orientation orientation)
 {
 	const struct ili9xxx_config *config = dev->config;
 	struct ili9xxx_data *data = dev->data;

 	int r;
 	uint8_t tx_data = ILI9XXX_MADCTL_BGR;
 	if (config->quirks->cmd_set == CMD_SET_1) {
 		if (orientation == DISPLAY_ORIENTATION_NORMAL) {
 			tx_data |= ILI9XXX_MADCTL_MX;
 		} else if (orientation == DISPLAY_ORIENTATION_ROTATED_90) {
 			tx_data |= ILI9XXX_MADCTL_MV;
 		} else if (orientation == DISPLAY_ORIENTATION_ROTATED_180) {
 			tx_data |= ILI9XXX_MADCTL_MY;
 		} else if (orientation == DISPLAY_ORIENTATION_ROTATED_270) {
 			tx_data |= ILI9XXX_MADCTL_MV | ILI9XXX_MADCTL_MX |
 				   ILI9XXX_MADCTL_MY;
 		}
 	} else if (config->quirks->cmd_set == CMD_SET_2) {
 		if (orientation == DISPLAY_ORIENTATION_NORMAL) {
 			/* Do nothing */
 		} else if (orientation == DISPLAY_ORIENTATION_ROTATED_90) {
 			tx_data |= ILI9XXX_MADCTL_MV | ILI9XXX_MADCTL_MY;
 		} else if (orientation == DISPLAY_ORIENTATION_ROTATED_180) {
 			tx_data |= ILI9XXX_MADCTL_MY | ILI9XXX_MADCTL_MX;
 		} else if (orientation == DISPLAY_ORIENTATION_ROTATED_270) {
 			tx_data |= ILI9XXX_MADCTL_MV | ILI9XXX_MADCTL_MX;
 		}
 	}

 	r = ili9xxx_transmit(dev, ILI9XXX_MADCTL, &tx_data, 1U);
 	if (r < 0) {
 		return r;
 	}

 	data->orientation = orientation;

 	return 0;
 }

 static void ili9xxx_get_capabilities(const struct device *dev,
 				     struct display_capabilities *capabilities)
 {
 	struct ili9xxx_data *data = dev->data;
 	const struct ili9xxx_config *config = dev->config;

 	memset(capabilities, 0, sizeof(struct display_capabilities));

 	capabilities->supported_pixel_formats =
 		PIXEL_FORMAT_RGB_565 | PIXEL_FORMAT_RGB_888;
 	capabilities->current_pixel_format = data->pixel_format;

 	if (data->orientation == DISPLAY_ORIENTATION_NORMAL ||
 	    data->orientation == DISPLAY_ORIENTATION_ROTATED_180) {
 		capabilities->x_resolution = config->x_resolution;
 		capabilities->y_resolution = config->y_resolution;
 	} else {
 		capabilities->x_resolution = config->y_resolution;
 		capabilities->y_resolution = config->x_resolution;
 	}

 	capabilities->current_orientation = data->orientation;
 }

 static int ili9xxx_configure(const struct device *dev)
 {
 	const struct ili9xxx_config *config = dev->config;

 	int r;
 	enum display_pixel_format pixel_format;
 	enum display_orientation orientation;

 	/* pixel format */
 	if (config->pixel_format == ILI9XXX_PIXEL_FORMAT_RGB565) {
 		pixel_format = PIXEL_FORMAT_RGB_565;
 	} else {
 		pixel_format = PIXEL_FORMAT_RGB_888;
 	}

 	r = ili9xxx_set_pixel_format(dev, pixel_format);
 	if (r < 0) {
 		return r;
 	}

 	/* orientation */
 	if (config->rotation == 0U) {
 		orientation = DISPLAY_ORIENTATION_NORMAL;
 	} else if (config->rotation == 90U) {
 		orientation = DISPLAY_ORIENTATION_ROTATED_90;
 	} else if (config->rotation == 180U) {
 		orientation = DISPLAY_ORIENTATION_ROTATED_180;
 	} else {
 		orientation = DISPLAY_ORIENTATION_ROTATED_270;
 	}

 	r = ili9xxx_set_orientation(dev, orientation);
 	if (r < 0) {
 		return r;
 	}

 	if (config->inversion) {
 		r = ili9xxx_transmit(dev, ILI9XXX_DINVON, NULL, 0U);
 		if (r < 0) {
 			return r;
 		}
 	}

 	r = config->regs_init_fn(dev);
 	if (r < 0) {
 		return r;
 	}

 	return 0;
 }

 static int ili9xxx_init(const struct device *dev)
 {
 	const struct ili9xxx_config *config = dev->config;

 	int r;

 	if (!spi_is_ready_dt(&config->spi)) {
 		LOG_ERR("SPI device is not ready");
 		return -ENODEV;
 	}

 	if (!device_is_ready(config->cmd_data.port)) {
 		LOG_ERR("Command/Data GPIO device not ready");
 		return -ENODEV;
 	}

 	r = gpio_pin_configure_dt(&config->cmd_data, GPIO_OUTPUT);
 	if (r < 0) {
 		LOG_ERR("Could not configure command/data GPIO (%d)", r);
 		return r;
 	}

 	if (config->reset.port != NULL) {
 		if (!device_is_ready(config->reset.port)) {
 			LOG_ERR("Reset GPIO device not ready");
 			return -ENODEV;
 		}

 		r = gpio_pin_configure_dt(&config->reset, GPIO_OUTPUT_INACTIVE);
 		if (r < 0) {
 			LOG_ERR("Could not configure reset GPIO (%d)", r);
 			return r;
 		}
 	}

 	ili9xxx_hw_reset(dev);

 	r = ili9xxx_transmit(dev, ILI9XXX_SWRESET, NULL, 0);
 	if (r < 0) {
 		LOG_ERR("Error transmit command Software Reset (%d)", r);
 		return r;
 	}

 	k_sleep(K_MSEC(ILI9XXX_RESET_WAIT_TIME));

 	ili9xxx_display_blanking_on(dev);

 	r = ili9xxx_configure(dev);
 	if (r < 0) {
 		LOG_ERR("Could not configure display (%d)", r);
 		return r;
 	}

 	r = ili9xxx_exit_sleep(dev);
 	if (r < 0) {
 		LOG_ERR("Could not exit sleep mode (%d)", r);
 		return r;
 	}

 	return 0;
 }

 static const struct display_driver_api ili9xxx_api = {
 	.blanking_on = ili9xxx_display_blanking_on,
 	.blanking_off = ili9xxx_display_blanking_off,
 	.write = ili9xxx_write,
 	.read = ili9xxx_read,
 	.get_framebuffer = ili9xxx_get_framebuffer,
 	.set_brightness = ili9xxx_set_brightness,
 	.set_contrast = ili9xxx_set_contrast,
 	.get_capabilities = ili9xxx_get_capabilities,
 	.set_pixel_format = ili9xxx_set_pixel_format,
 	.set_orientation = ili9xxx_set_orientation,
 };

 #ifdef CONFIG_ILI9340
 static const struct ili9xxx_quirks ili9340_quirks = {
 	.cmd_set = CMD_SET_1,
 };
 #endif

 #ifdef CONFIG_ILI9341
 static const struct ili9xxx_quirks ili9341_quirks = {
 	.cmd_set = CMD_SET_1,
 };
 #endif

 #ifdef CONFIG_ILI9342C
 static const struct ili9xxx_quirks ili9342c_quirks = {
 	.cmd_set = CMD_SET_2,
 };
 #endif

 #ifdef CONFIG_ILI9488
 static const struct ili9xxx_quirks ili9488_quirks = {
 	.cmd_set = CMD_SET_1,
 };
 #endif

 #define INST_DT_ILI9XXX(n, t) DT_INST(n, ilitek_ili##t)

 #define ILI9XXX_INIT(n, t)                                                     \
 	ILI##t##_REGS_INIT(n);                                                 \
 									       \
 	static const struct ili9xxx_config ili9xxx_config_##n = {              \
 		.quirks = &ili##t##_quirks,                                    \
 		.spi = SPI_DT_SPEC_GET(INST_DT_ILI9XXX(n, t),                  \
 				       SPI_OP_MODE_MASTER | SPI_WORD_SET(8),   \
 				       0),                                     \
 		.cmd_data = GPIO_DT_SPEC_GET(INST_DT_ILI9XXX(n, t),            \
 					     cmd_data_gpios),                  \
 		.reset = GPIO_DT_SPEC_GET_OR(INST_DT_ILI9XXX(n, t),            \
 					     reset_gpios, {0}),                \
 		.pixel_format = DT_PROP(INST_DT_ILI9XXX(n, t), pixel_format),  \
 		.rotation = DT_PROP(INST_DT_ILI9XXX(n, t), rotation),          \
 		.x_resolution = ILI##t##_X_RES,                                \
 		.y_resolution = ILI##t##_Y_RES,                                \
 		.inversion = DT_PROP(INST_DT_ILI9XXX(n, t), display_inversion),\
 		.regs = &ili9xxx_regs_##n,                                     \
 		.regs_init_fn = ili##t##_regs_init,                            \
 	};                                                                     \
 									       \
 	static struct ili9xxx_data ili9xxx_data_##n;                           \
 									       \
 	DEVICE_DT_DEFINE(INST_DT_ILI9XXX(n, t), ili9xxx_init,                  \
 			    NULL, &ili9xxx_data_##n,                           \
 			    &ili9xxx_config_##n, POST_KERNEL,                  \
 			    CONFIG_DISPLAY_INIT_PRIORITY, &ili9xxx_api)

 #define DT_INST_FOREACH_ILI9XXX_STATUS_OKAY(t)                                 \
 	LISTIFY(DT_NUM_INST_STATUS_OKAY(ilitek_ili##t), ILI9XXX_INIT, (;), t)

 #ifdef CONFIG_ILI9340
 #include "display_ili9340.h"
 DT_INST_FOREACH_ILI9XXX_STATUS_OKAY(9340);
 #endif

 #ifdef CONFIG_ILI9341
 #include "display_ili9341.h"
 DT_INST_FOREACH_ILI9XXX_STATUS_OKAY(9341);
 #endif

 #ifdef CONFIG_ILI9342C
 #include "display_ili9342c.h"
 DT_INST_FOREACH_ILI9XXX_STATUS_OKAY(9342c);
 #endif

 #ifdef CONFIG_ILI9488
 #include "display_ili9488.h"
 DT_INST_FOREACH_ILI9XXX_STATUS_OKAY(9488);
 #endif
	/*
	* Copyright (c) 2017 Jan Van Winkel <jan.van_winkel@dxplore.eu>
	* Copyright (c) 2019 Nordic Semiconductor ASA
	* Copyright (c) 2020 Teslabs Engineering S.L.
	* Copyright (c) 2021 Krivorot Oleg <krivorot.oleg@gmail.com>
	* SPDX-License-Identifier: Apache-2.0
	*/

	#include "display_ili9xxx.h"

	#include <zephyr/dt-bindings/display/ili9xxx.h>
	#include <zephyr/drivers/display.h>
	#include <zephyr/sys/byteorder.h>

	#include <zephyr/logging/log.h>
	LOG_MODULE_REGISTER(display_ili9xxx, CONFIG_DISPLAY_LOG_LEVEL);

	struct ili9xxx_data {
	uint8_t bytes_per_pixel;
	enum display_pixel_format pixel_format;
	enum display_orientation orientation;
	};

	int ili9xxx_transmit(const struct device dev, uint8_t cmd, const void tx_data,
	size_t tx_len)
	{
	const struct ili9xxx_config *config = dev->config;

	int r;
	struct spi_buf tx_buf;
	struct spi_buf_set tx_bufs = { .buffers = &tx_buf, .count = 1U };

	/* send command */
	tx_buf.buf = &cmd;
	tx_buf.len = 1U;

	gpio_pin_set_dt(&config->cmd_data, ILI9XXX_CMD);
	r = spi_write_dt(&config->spi, &tx_bufs);
	if (r < 0) {
	return r;
	}

	/* send data (if any) */
	if (tx_data != NULL) {
	tx_buf.buf = (void *)tx_data;
	tx_buf.len = tx_len;

	gpio_pin_set_dt(&config->cmd_data, ILI9XXX_DATA);
	r = spi_write_dt(&config->spi, &tx_bufs);
	if (r < 0) {
	return r;
	}
	}

	return 0;
	}

	static int ili9xxx_exit_sleep(const struct device *dev)
	{
	int r;

	r = ili9xxx_transmit(dev, ILI9XXX_SLPOUT, NULL, 0);
	if (r < 0) {
	return r;
	}

	k_sleep(K_MSEC(ILI9XXX_SLEEP_OUT_TIME));

	return 0;
	}

	static void ili9xxx_hw_reset(const struct device *dev)
	{
	const struct ili9xxx_config *config = dev->config;

	if (config->reset.port == NULL) {
	return;
	}

	gpio_pin_set_dt(&config->reset, 1);
	k_sleep(K_MSEC(ILI9XXX_RESET_PULSE_TIME));
	gpio_pin_set_dt(&config->reset, 0);

	k_sleep(K_MSEC(ILI9XXX_RESET_WAIT_TIME));
	}

	static int ili9xxx_set_mem_area(const struct device *dev, const uint16_t x,
	const uint16_t y, const uint16_t w,
	const uint16_t h)
	{
	int r;
	uint16_t spi_data[2];

	spi_data[0] = sys_cpu_to_be16(x);
	spi_data[1] = sys_cpu_to_be16(x + w - 1U);
	r = ili9xxx_transmit(dev, ILI9XXX_CASET, &spi_data[0], 4U);
	if (r < 0) {
	return r;
	}

	spi_data[0] = sys_cpu_to_be16(y);
	spi_data[1] = sys_cpu_to_be16(y + h - 1U);
	r = ili9xxx_transmit(dev, ILI9XXX_PASET, &spi_data[0], 4U);
	if (r < 0) {
	return r;
	}

	return 0;
	}

	static int ili9xxx_write(const struct device *dev, const uint16_t x,
	const uint16_t y,
	const struct display_buffer_descriptor *desc,
	const void *buf)
	{
	const struct ili9xxx_config *config = dev->config;
	struct ili9xxx_data *data = dev->data;

	int r;
	const uint8_t write_data_start = (const uint8_t )buf;
	struct spi_buf tx_buf;
	struct spi_buf_set tx_bufs;
	uint16_t write_cnt;
	uint16_t nbr_of_writes;
	uint16_t write_h;

	__ASSERT(desc->width <= desc->pitch, "Pitch is smaller than width");
	__ASSERT((desc->pitch * data->bytes_per_pixel * desc->height) <=
	desc->buf_size,
	"Input buffer to small");

	LOG_DBG("Writing %dx%d (w,h) @ %dx%d (x,y)", desc->width, desc->height,
	x, y);
	r = ili9xxx_set_mem_area(dev, x, y, desc->width, desc->height);
	if (r < 0) {
	return r;
	}

	if (desc->pitch > desc->width) {
	write_h = 1U;
	nbr_of_writes = desc->height;
	} else {
	write_h = desc->height;
	nbr_of_writes = 1U;
	}

	r = ili9xxx_transmit(dev, ILI9XXX_RAMWR, write_data_start,
	desc->width * data->bytes_per_pixel * write_h);
	if (r < 0) {
	return r;
	}

	tx_bufs.buffers = &tx_buf;
	tx_bufs.count = 1;

	write_data_start += desc->pitch * data->bytes_per_pixel;
	for (write_cnt = 1U; write_cnt < nbr_of_writes; ++write_cnt) {
	tx_buf.buf = (void *)write_data_start;
	tx_buf.len = desc->width * data->bytes_per_pixel * write_h;

	r = spi_write_dt(&config->spi, &tx_bufs);
	if (r < 0) {
	return r;
	}

	write_data_start += desc->pitch * data->bytes_per_pixel;
	}

	return 0;
	}

	static int ili9xxx_read(const struct device *dev, const uint16_t x,
	const uint16_t y,
	const struct display_buffer_descriptor desc, void buf)
	{
	LOG_ERR("Reading not supported");
	return -ENOTSUP;
	}

	static void ili9xxx_get_framebuffer(const struct device dev)
	{
	LOG_ERR("Direct framebuffer access not supported");
	return NULL;
	}

	static int ili9xxx_display_blanking_off(const struct device *dev)
	{
	LOG_DBG("Turning display blanking off");
	return ili9xxx_transmit(dev, ILI9XXX_DISPON, NULL, 0);
	}

	static int ili9xxx_display_blanking_on(const struct device *dev)
	{
	LOG_DBG("Turning display blanking on");
	return ili9xxx_transmit(dev, ILI9XXX_DISPOFF, NULL, 0);
	}

	static int ili9xxx_set_brightness(const struct device *dev,
	const uint8_t brightness)
	{
	LOG_ERR("Set brightness not implemented");
	return -ENOTSUP;
	}

	static int ili9xxx_set_contrast(const struct device *dev,
	const uint8_t contrast)
	{
	LOG_ERR("Set contrast not supported");
	return -ENOTSUP;
	}

	static int
	ili9xxx_set_pixel_format(const struct device *dev,
	const enum display_pixel_format pixel_format)
	{
	struct ili9xxx_data *data = dev->data;

	int r;
	uint8_t tx_data;
	uint8_t bytes_per_pixel;

	if (pixel_format == PIXEL_FORMAT_RGB_565) {
	bytes_per_pixel = 2U;
	tx_data = ILI9XXX_PIXSET_MCU_16_BIT \| ILI9XXX_PIXSET_RGB_16_BIT;
	} else if (pixel_format == PIXEL_FORMAT_RGB_888) {
	bytes_per_pixel = 3U;
	tx_data = ILI9XXX_PIXSET_MCU_18_BIT \| ILI9XXX_PIXSET_RGB_18_BIT;
	} else {
	LOG_ERR("Unsupported pixel format");
	return -ENOTSUP;
	}

	r = ili9xxx_transmit(dev, ILI9XXX_PIXSET, &tx_data, 1U);
	if (r < 0) {
	return r;
	}

	data->pixel_format = pixel_format;
	data->bytes_per_pixel = bytes_per_pixel;

	return 0;
	}

	static int ili9xxx_set_orientation(const struct device *dev,
	const enum display_orientation orientation)
	{
	const struct ili9xxx_config *config = dev->config;
	struct ili9xxx_data *data = dev->data;

	int r;
	uint8_t tx_data = ILI9XXX_MADCTL_BGR;
	if (config->quirks->cmd_set == CMD_SET_1) {
	if (orientation == DISPLAY_ORIENTATION_NORMAL) {
	tx_data \|= ILI9XXX_MADCTL_MX;
	} else if (orientation == DISPLAY_ORIENTATION_ROTATED_90) {
	tx_data \|= ILI9XXX_MADCTL_MV;
	} else if (orientation == DISPLAY_ORIENTATION_ROTATED_180) {
	tx_data \|= ILI9XXX_MADCTL_MY;
	} else if (orientation == DISPLAY_ORIENTATION_ROTATED_270) {
	tx_data \|= ILI9XXX_MADCTL_MV \| ILI9XXX_MADCTL_MX \|
	ILI9XXX_MADCTL_MY;
	}
	} else if (config->quirks->cmd_set == CMD_SET_2) {
	if (orientation == DISPLAY_ORIENTATION_NORMAL) {
	/* Do nothing */
	} else if (orientation == DISPLAY_ORIENTATION_ROTATED_90) {
	tx_data \|= ILI9XXX_MADCTL_MV \| ILI9XXX_MADCTL_MY;
	} else if (orientation == DISPLAY_ORIENTATION_ROTATED_180) {
	tx_data \|= ILI9XXX_MADCTL_MY \| ILI9XXX_MADCTL_MX;
	} else if (orientation == DISPLAY_ORIENTATION_ROTATED_270) {
	tx_data \|= ILI9XXX_MADCTL_MV \| ILI9XXX_MADCTL_MX;
	}
	}

	r = ili9xxx_transmit(dev, ILI9XXX_MADCTL, &tx_data, 1U);
	if (r < 0) {
	return r;
	}

	data->orientation = orientation;

	return 0;
	}

	static void ili9xxx_get_capabilities(const struct device *dev,
	struct display_capabilities *capabilities)
	{
	struct ili9xxx_data *data = dev->data;
	const struct ili9xxx_config *config = dev->config;

	memset(capabilities, 0, sizeof(struct display_capabilities));

	capabilities->supported_pixel_formats =
	PIXEL_FORMAT_RGB_565 \| PIXEL_FORMAT_RGB_888;
	capabilities->current_pixel_format = data->pixel_format;

	if (data->orientation == DISPLAY_ORIENTATION_NORMAL \|\|
	data->orientation == DISPLAY_ORIENTATION_ROTATED_180) {
	capabilities->x_resolution = config->x_resolution;
	capabilities->y_resolution = config->y_resolution;
	} else {
	capabilities->x_resolution = config->y_resolution;
	capabilities->y_resolution = config->x_resolution;
	}

	capabilities->current_orientation = data->orientation;
	}

	static int ili9xxx_configure(const struct device *dev)
	{
	const struct ili9xxx_config *config = dev->config;

	int r;
	enum display_pixel_format pixel_format;
	enum display_orientation orientation;

	/* pixel format */
	if (config->pixel_format == ILI9XXX_PIXEL_FORMAT_RGB565) {
	pixel_format = PIXEL_FORMAT_RGB_565;
	} else {
	pixel_format = PIXEL_FORMAT_RGB_888;
	}

	r = ili9xxx_set_pixel_format(dev, pixel_format);
	if (r < 0) {
	return r;
	}

	/* orientation */
	if (config->rotation == 0U) {
	orientation = DISPLAY_ORIENTATION_NORMAL;
	} else if (config->rotation == 90U) {
	orientation = DISPLAY_ORIENTATION_ROTATED_90;
	} else if (config->rotation == 180U) {
	orientation = DISPLAY_ORIENTATION_ROTATED_180;
	} else {
	orientation = DISPLAY_ORIENTATION_ROTATED_270;
	}

	r = ili9xxx_set_orientation(dev, orientation);
	if (r < 0) {
	return r;
	}

	if (config->inversion) {
	r = ili9xxx_transmit(dev, ILI9XXX_DINVON, NULL, 0U);
	if (r < 0) {
	return r;
	}
	}

	r = config->regs_init_fn(dev);
	if (r < 0) {
	return r;
	}

	return 0;
	}

	static int ili9xxx_init(const struct device *dev)
	{
	const struct ili9xxx_config *config = dev->config;

	int r;

	if (!spi_is_ready_dt(&config->spi)) {
	LOG_ERR("SPI device is not ready");
	return -ENODEV;
	}

	if (!device_is_ready(config->cmd_data.port)) {
	LOG_ERR("Command/Data GPIO device not ready");
	return -ENODEV;
	}

	r = gpio_pin_configure_dt(&config->cmd_data, GPIO_OUTPUT);
	if (r < 0) {
	LOG_ERR("Could not configure command/data GPIO (%d)", r);
	return r;
	}

	if (config->reset.port != NULL) {
	if (!device_is_ready(config->reset.port)) {
	LOG_ERR("Reset GPIO device not ready");
	return -ENODEV;
	}

	r = gpio_pin_configure_dt(&config->reset, GPIO_OUTPUT_INACTIVE);
	if (r < 0) {
	LOG_ERR("Could not configure reset GPIO (%d)", r);
	return r;
	}
	}

	ili9xxx_hw_reset(dev);

	r = ili9xxx_transmit(dev, ILI9XXX_SWRESET, NULL, 0);
	if (r < 0) {
	LOG_ERR("Error transmit command Software Reset (%d)", r);
	return r;
	}

	k_sleep(K_MSEC(ILI9XXX_RESET_WAIT_TIME));

	ili9xxx_display_blanking_on(dev);

	r = ili9xxx_configure(dev);
	if (r < 0) {
	LOG_ERR("Could not configure display (%d)", r);
	return r;
	}

	r = ili9xxx_exit_sleep(dev);
	if (r < 0) {
	LOG_ERR("Could not exit sleep mode (%d)", r);
	return r;
	}

	return 0;
	}

	static const struct display_driver_api ili9xxx_api = {
	.blanking_on = ili9xxx_display_blanking_on,
	.blanking_off = ili9xxx_display_blanking_off,
	.write = ili9xxx_write,
	.read = ili9xxx_read,
	.get_framebuffer = ili9xxx_get_framebuffer,
	.set_brightness = ili9xxx_set_brightness,
	.set_contrast = ili9xxx_set_contrast,
	.get_capabilities = ili9xxx_get_capabilities,
	.set_pixel_format = ili9xxx_set_pixel_format,
	.set_orientation = ili9xxx_set_orientation,
	};

	#ifdef CONFIG_ILI9340
	static const struct ili9xxx_quirks ili9340_quirks = {
	.cmd_set = CMD_SET_1,
	};
	#endif

	#ifdef CONFIG_ILI9341
	static const struct ili9xxx_quirks ili9341_quirks = {
	.cmd_set = CMD_SET_1,
	};
	#endif

	#ifdef CONFIG_ILI9342C
	static const struct ili9xxx_quirks ili9342c_quirks = {
	.cmd_set = CMD_SET_2,
	};
	#endif

	#ifdef CONFIG_ILI9488
	static const struct ili9xxx_quirks ili9488_quirks = {
	.cmd_set = CMD_SET_1,
	};
	#endif

	#define INST_DT_ILI9XXX(n, t) DT_INST(n, ilitek_ili##t)

	#define ILI9XXX_INIT(n, t) \
	ILI##t##_REGS_INIT(n); \
	\
	static const struct ili9xxx_config ili9xxx_config_##n = { \
	.quirks = &ili##t##_quirks, \
	.spi = SPI_DT_SPEC_GET(INST_DT_ILI9XXX(n, t), \
	SPI_OP_MODE_MASTER \| SPI_WORD_SET(8), \
	0), \
	.cmd_data = GPIO_DT_SPEC_GET(INST_DT_ILI9XXX(n, t), \
	cmd_data_gpios), \
	.reset = GPIO_DT_SPEC_GET_OR(INST_DT_ILI9XXX(n, t), \
	reset_gpios, {0}), \
	.pixel_format = DT_PROP(INST_DT_ILI9XXX(n, t), pixel_format), \
	.rotation = DT_PROP(INST_DT_ILI9XXX(n, t), rotation), \
	.x_resolution = ILI##t##_X_RES, \
	.y_resolution = ILI##t##_Y_RES, \
	.inversion = DT_PROP(INST_DT_ILI9XXX(n, t), display_inversion),\
	.regs = &ili9xxx_regs_##n, \
	.regs_init_fn = ili##t##_regs_init, \
	}; \
	\
	static struct ili9xxx_data ili9xxx_data_##n; \
	\
	DEVICE_DT_DEFINE(INST_DT_ILI9XXX(n, t), ili9xxx_init, \
	NULL, &ili9xxx_data_##n, \
	&ili9xxx_config_##n, POST_KERNEL, \
	CONFIG_DISPLAY_INIT_PRIORITY, &ili9xxx_api)

	#define DT_INST_FOREACH_ILI9XXX_STATUS_OKAY(t) \
	LISTIFY(DT_NUM_INST_STATUS_OKAY(ilitek_ili##t), ILI9XXX_INIT, (;), t)

	#ifdef CONFIG_ILI9340
	#include "display_ili9340.h"
	DT_INST_FOREACH_ILI9XXX_STATUS_OKAY(9340);
	#endif

	#ifdef CONFIG_ILI9341
	#include "display_ili9341.h"
	DT_INST_FOREACH_ILI9XXX_STATUS_OKAY(9341);
	#endif

	#ifdef CONFIG_ILI9342C
	#include "display_ili9342c.h"
	DT_INST_FOREACH_ILI9XXX_STATUS_OKAY(9342c);
	#endif

	#ifdef CONFIG_ILI9488
	#include "display_ili9488.h"
	DT_INST_FOREACH_ILI9XXX_STATUS_OKAY(9488);
	#endif