commit 527591a76619d8680145189c766c8e690da4149c
author Emil Gydesen <emil.gydesen@nordicsemi.no> Wed May 24 21:30:39 2023 +0200
committer Anas Nashif <anas.nashif@intel.com> Fri May 26 09:08:42 2023 -0400
tree 0d17488129b2476435a508e21f4e1ee509c5d8d0
parent 75637bd44a20f58e9073d38771f64004f15ddfc3

Bluetooth: BAP: Fix off-by-one in shell cmd add_broadcast_id

The arguments in the shell start from [1] as [0] is the command
itself.

Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>

subsys/bluetooth/audio/shell/bap_broadcast_assistant.c

diff --git a/subsys/bluetooth/audio/shell/bap_broadcast_assistant.c b/subsys/bluetooth/audio/shell/bap_broadcast_assistant.c
index 0505d56..005958e 100644
--- a/subsys/bluetooth/audio/shell/bap_broadcast_assistant.c
+++ b/subsys/bluetooth/audio/shell/bap_broadcast_assistant.c
@@ -600,7 +600,7 @@
 		return -ENOEXEC;
 	}
 
-	broadcast_id = shell_strtoul(argv[0], 0, &err);
+	broadcast_id = shell_strtoul(argv[1], 0, &err);
 	if (err != 0) {
 		shell_error(sh, "failed to parse broadcast_id: %d", err);
 
@@ -611,7 +611,7 @@
 		return -ENOEXEC;
 	}
 
-	pa_sync = shell_strtoul(argv[1], 0, &err);
+	pa_sync = shell_strtoul(argv[2], 0, &err);
 	if (err != 0) {
 		shell_error(sh, "failed to parse pa_sync: %d", err);
 
@@ -623,8 +623,8 @@
 	}
 
 	/* TODO: Support multiple subgroups */
-	if (argc > 2) {
-		const unsigned long bis_sync = shell_strtoul(argv[2], 0, &err);
+	if (argc > 3) {
+		const unsigned long bis_sync = shell_strtoul(argv[3], 0, &err);
 
 		if (err != 0) {
 			shell_error(sh, "failed to parse bis_sync: %d", err);
@@ -639,9 +639,8 @@
 		subgroup.bis_sync = bis_sync;
 	}
 
-	if (argc > 3) {
-		subgroup.metadata_len = hex2bin(argv[3], strlen(argv[3]),
-						subgroup.metadata,
+	if (argc > 4) {
+		subgroup.metadata_len = hex2bin(argv[4], strlen(argv[4]), subgroup.metadata,
 						sizeof(subgroup.metadata));
 
 		if (subgroup.metadata_len == 0U) {